Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: webrtc/media/base/audiorenderer.h

Issue 1741933002: Prevent a voice channel from sending data before a renderer is set. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Merge with master Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/base/audiorenderer.h
diff --git a/webrtc/media/base/audiorenderer.h b/webrtc/media/base/audiorenderer.h
deleted file mode 100644
index 4544c7fc634aeb96cb56b922df5929199e8b3664..0000000000000000000000000000000000000000
--- a/webrtc/media/base/audiorenderer.h
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
- * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#ifndef WEBRTC_MEDIA_BASE_AUDIORENDERER_H_
-#define WEBRTC_MEDIA_BASE_AUDIORENDERER_H_
-
-#include <cstddef>
-
-namespace cricket {
-
-// Abstract interface for rendering the audio data.
-class AudioRenderer {
pthatcher1 2016/03/08 17:46:51 We should make sure this doesn't break the Chrome
- public:
- class Sink {
- public:
- // Callback to receive data from the AudioRenderer.
- virtual void OnData(const void* audio_data,
- int bits_per_sample,
- int sample_rate,
- size_t number_of_channels,
- size_t number_of_frames) = 0;
-
- // Called when the AudioRenderer is going away.
- virtual void OnClose() = 0;
-
- protected:
- virtual ~Sink() {}
- };
-
- // Sets a sink to the AudioRenderer. There can be only one sink connected
- // to the renderer at a time.
- virtual void SetSink(Sink* sink) {}
-
- protected:
- virtual ~AudioRenderer() {}
-};
-
-} // namespace cricket
-
-#endif // WEBRTC_MEDIA_BASE_AUDIORENDERER_H_

Powered by Google App Engine
This is Rietveld 408576698