webrtc/media/engine/webrtcvoiceengine.h - Issue 1741933002: Prevent a voice channel from sending data before a renderer is set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvoiceengine.h

Issue 1741933002: Prevent a voice channel from sending data before a renderer is set. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixing unit test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/engine/webrtcvoiceengine.h

diff --git a/webrtc/media/engine/webrtcvoiceengine.h b/webrtc/media/engine/webrtcvoiceengine.h

index dbb7ea6e76715a811b75a9b907c0e7c4b077fef1..9e424978775b9ceadc717ed4490dd55da201bfba 100644

--- a/webrtc/media/engine/webrtcvoiceengine.h

+++ b/webrtc/media/engine/webrtcvoiceengine.h

@@ -226,7 +226,9 @@ class WebRtcVoiceMediaChannel final : public VoiceMediaChannel,

bool SetSendCodec(int channel, const webrtc::CodecInst& send_codec);

bool ChangePlayout(bool playout);

bool ChangeSend(SendFlags send);

- bool ChangeSend(int channel, SendFlags send);

+ // Update the send state for the channel associated with |ssrc|,

+ // according to |send| and whether or not the send stream is rendering.

+ bool UpdateChannelSendState(uint32_t ssrc, SendFlags send);

int CreateVoEChannel();

bool DeleteVoEChannel(int channel);

bool IsDefaultRecvStream(uint32_t ssrc) {

« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine.cc » ('j') | webrtc/media/engine/webrtcvoiceengine.cc » ('J')