Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: webrtc/audio/audio_send_stream.cc

Issue 1741933002: Prevent a voice channel from sending data before a renderer is set. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding a TODO and returning a const pointer. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/audio/audio_send_stream.cc
diff --git a/webrtc/audio/audio_send_stream.cc b/webrtc/audio/audio_send_stream.cc
index c18331cea6c21dc83766ee869585ec0e9a42437a..fa632b348d147adfa578dede5cb0c1845e5f4a4b 100644
--- a/webrtc/audio/audio_send_stream.cc
+++ b/webrtc/audio/audio_send_stream.cc
@@ -97,10 +97,16 @@ AudioSendStream::~AudioSendStream() {
void AudioSendStream::Start() {
RTC_DCHECK(thread_checker_.CalledOnValidThread());
+ ScopedVoEInterface<VoEBase> base(voice_engine());
+ int error = base->StartSend(config_.voe_channel_id);
+ RTC_DCHECK_EQ(0, error);
the sun 2016/03/07 21:24:53 I don't think a DCHECK is appropriate here. There
Taylor Brandstetter 2016/03/08 00:00:31 Done.
}
void AudioSendStream::Stop() {
RTC_DCHECK(thread_checker_.CalledOnValidThread());
+ ScopedVoEInterface<VoEBase> base(voice_engine());
+ int error = base->StopSend(config_.voe_channel_id);
+ RTC_DCHECK_EQ(0, error);
}
void AudioSendStream::SignalNetworkState(NetworkState state) {

Powered by Google App Engine
This is Rietveld 408576698