webrtc/pc/channel.h - Issue 1741933002: Prevent a voice channel from sending data before a renderer is set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/channel.h

Issue 1741933002: Prevent a voice channel from sending data before a renderer is set. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Adding unit test for the original problem this CL solves. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/pc/channel.h

diff --git a/webrtc/pc/channel.h b/webrtc/pc/channel.h

index f72818924d598b062280e858711e05ea8c702add..30432819d1d41d77226e26995d51abc75689d2b0 100644

--- a/webrtc/pc/channel.h

+++ b/webrtc/pc/channel.h

@@ -336,7 +336,7 @@ class VoiceChannel : public BaseChannel {

bool SetAudioSend(uint32_t ssrc,

bool enable,

const AudioOptions* options,

- AudioRenderer* renderer);

+ AudioSource* source);

// downcasts a MediaChannel

virtual VoiceMediaChannel* media_channel() const {

« webrtc/api/webrtcsession_unittest.cc ('K') | « webrtc/media/media.gyp ('k') | webrtc/pc/channel.cc » ('j') | no next file with comments »