webrtc/audio/audio_send_stream.cc - Issue 1741933002: Prevent a voice channel from sending data before a renderer is set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/audio/audio_send_stream.cc

Issue 1741933002: Prevent a voice channel from sending data before a renderer is set. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Adding unit test for the original problem this CL solves. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/audio/audio_send_stream.cc

diff --git a/webrtc/audio/audio_send_stream.cc b/webrtc/audio/audio_send_stream.cc

index c18331cea6c21dc83766ee869585ec0e9a42437a..fa632b348d147adfa578dede5cb0c1845e5f4a4b 100644

--- a/webrtc/audio/audio_send_stream.cc

+++ b/webrtc/audio/audio_send_stream.cc

@@ -97,10 +97,16 @@ AudioSendStream::~AudioSendStream() {

void AudioSendStream::Start() {

RTC_DCHECK(thread_checker_.CalledOnValidThread());

+ ScopedVoEInterface<VoEBase> base(voice_engine());

+ int error = base->StartSend(config_.voe_channel_id);

+ RTC_DCHECK_EQ(0, error);

}

void AudioSendStream::Stop() {

RTC_DCHECK(thread_checker_.CalledOnValidThread());

+ ScopedVoEInterface<VoEBase> base(voice_engine());

+ int error = base->StopSend(config_.voe_channel_id);

+ RTC_DCHECK_EQ(0, error);

}

void AudioSendStream::SignalNetworkState(NetworkState state) {

« webrtc/api/webrtcsession_unittest.cc ('K') | « webrtc/api/webrtcsession_unittest.cc ('k') | webrtc/media/base/audiorenderer.h » ('j') | no next file with comments »