webrtc/api/rtpsenderreceiver_unittest.cc - Issue 1741933002: Prevent a voice channel from sending data before a renderer is set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/rtpsenderreceiver_unittest.cc

Issue 1741933002: Prevent a voice channel from sending data before a renderer is set. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Adding unit test for the original problem this CL solves. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/rtpsenderreceiver_unittest.cc

diff --git a/webrtc/api/rtpsenderreceiver_unittest.cc b/webrtc/api/rtpsenderreceiver_unittest.cc

index 60960fb5f043addb2ef32df4388e412fb6580460..4143d13a9073e9c9d4159bfb4fd393ef44f9787c 100644

--- a/webrtc/api/rtpsenderreceiver_unittest.cc

+++ b/webrtc/api/rtpsenderreceiver_unittest.cc

@@ -50,7 +50,7 @@ class MockAudioProvider : public AudioProviderInterface {

void(uint32_t ssrc,

bool enable,

const cricket::AudioOptions& options,

- cricket::AudioRenderer* renderer));

+ cricket::AudioSource* source));

MOCK_METHOD2(SetAudioPlayoutVolume, void(uint32_t ssrc, double volume));

void SetRawAudioSink(uint32_t,

« no previous file with comments | « webrtc/api/rtpsender.cc ('k') | webrtc/api/webrtcsession.h » ('j') | webrtc/api/webrtcsession_unittest.cc » ('J')