Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1741723002: jni_helpers: Optimize IsNull() (Closed)

Created:
4 years, 10 months ago by magjed_webrtc
Modified:
4 years, 9 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

jni_helpers: Optimize IsNull() The current implementation is unnecessary expensive - we create a local reference frame for creating new Java objects and then create a new local reference. It's cheaper to just do jni->IsSameObject(obj, nullptr). R=perkj@webrtc.org Committed: https://crrev.com/ffdd41ecf2180c4f52f003915a4bd514bb5e5736 Cr-Commit-Position: refs/heads/master@{#11825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M webrtc/api/java/jni/jni_helpers.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/api/java/jni/jni_helpers.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
magjed_webrtc
perkj - Please take a look.
4 years, 10 months ago (2016-02-26 10:45:51 UTC) #3
perkj_webrtc
lgtm
4 years, 10 months ago (2016-02-26 11:58:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741723002/1
4 years, 9 months ago (2016-02-29 08:43:23 UTC) #6
commit-bot: I haz the power
Exceeded global retry quota
4 years, 9 months ago (2016-02-29 08:53:54 UTC) #8
magjed_webrtc
Committed patchset #1 (id:1) manually as ffdd41ecf2180c4f52f003915a4bd514bb5e5736 (presubmit successful).
4 years, 9 months ago (2016-03-01 09:10:17 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 09:10:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffdd41ecf2180c4f52f003915a4bd514bb5e5736
Cr-Commit-Position: refs/heads/master@{#11825}

Powered by Google App Engine
This is Rietveld 408576698