Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1741413002: Lazily allocate output buffer for AsyncTCPSocket. (Closed)

Created:
4 years, 9 months ago by joachim
Modified:
4 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Lazily allocate output buffer for AsyncTCPSocket. As a follow-up to https://codereview.webrtc.org/1737053006/ this CL further improves memory usage by lazily allocating output buffers up to the passed maximum size. This also changes the output buffer to a Buffer object. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M webrtc/base/asynctcpsocket.h View 3 chunks +6 lines, -4 lines 0 comments Download
M webrtc/base/asynctcpsocket.cc View 3 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
joachim
Ptal
4 years, 9 months ago (2016-02-28 16:32:39 UTC) #2
tommi
Lgtm. Can you fix the last sentence in the cl description before committing?
4 years, 9 months ago (2016-02-28 17:23:00 UTC) #3
joachim
On 2016/02/28 17:23:00, tommi-webrtc wrote: > Lgtm. Can you fix the last sentence in the ...
4 years, 9 months ago (2016-02-28 17:47:38 UTC) #6
tommi
lgtm
4 years, 9 months ago (2016-02-28 23:00:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741413002/1
4 years, 9 months ago (2016-02-28 23:01:04 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/250fc658c56cb3c6944bd0fd1b88973f2e6d1ced Cr-Commit-Position: refs/heads/master@{#11801}
4 years, 9 months ago (2016-02-28 23:06:53 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-02-28 23:06:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698