Chromium Code Reviews

Issue 1740963002: Revert of Removed unused cricket::VideoCapturer methods (Closed)

Created:
4 years, 10 months ago by perkj_webrtc
Modified:
4 years, 10 months ago
Reviewers:
magjed_webrtc, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Removed unused cricket::VideoCapturer methods (patchset #2 id:30001 of https://codereview.webrtc.org/1733673002/ ) Reason for revert: Breaks remoting::protocol::WebrtcVideoCapturerAdapter::Pause' See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/3689/steps/compile/logs/stdio Original issue's description: > Removed unused cricket::VideoCapturer methods: > > void UpdateAspectRatio(int ratio_w, int ratio_h); > void ClearAspectRatio(); > ool Pause(bool paused); > Restart(const VideoFormat& capture_format); > MuteToBlackThenPause(bool muted); > IsMuted() const > set_square_pixel_aspect_ratio > bool square_pixel_aspect_ratio() > > This cl also remove the use of messages and posting of state change. > Further more - a thread checker is added to make sure methods are called on only one thread. Construction can happen on a separate thred. > It does not add restrictions on what thread frames are delivered on though. > > There is more features in VideoCapturer::Onframe related to screen share in ARGB that probably can be cleaned up in a follow up cl. > > BUG=webrtc:5426 > > Committed: https://crrev.com/e9c0cdff2dad2553b6ff6820c0c7429cb2854861 > Cr-Commit-Position: refs/heads/master@{#11773} TBR=magjed@webrtc.org,pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5426 Committed: https://crrev.com/74622e061320d9fab4388c260b2d806de4b34e2f Cr-Commit-Position: refs/heads/master@{#11777}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+449 lines, -43 lines)
M webrtc/api/androidvideocapturer.cc View 2 chunks +6 lines, -2 lines 0 comments
M webrtc/api/test/fakeperiodicvideocapturer.h View 2 chunks +3 lines, -2 lines 0 comments
M webrtc/api/videosource.cc View 2 chunks +2 lines, -1 line 0 comments
M webrtc/media/base/capturemanager.h View 1 chunk +9 lines, -0 lines 0 comments
M webrtc/media/base/capturemanager.cc View 1 chunk +56 lines, -0 lines 0 comments
M webrtc/media/base/capturemanager_unittest.cc View 1 chunk +38 lines, -0 lines 0 comments
M webrtc/media/base/videocapturer.h View 11 chunks +44 lines, -5 lines 0 comments
M webrtc/media/base/videocapturer.cc View 13 chunks +167 lines, -25 lines 0 comments
M webrtc/media/base/videocapturer_unittest.cc View 5 chunks +91 lines, -0 lines 0 comments
M webrtc/media/engine/webrtcvideocapturer.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/media/engine/webrtcvideocapturer_unittest.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +8 lines, -6 lines 0 comments
M webrtc/pc/channelmanager.h View 1 chunk +3 lines, -0 lines 0 comments
M webrtc/pc/channelmanager.cc View 1 chunk +20 lines, -0 lines 0 comments

Messages

Total messages: 6 (2 generated)
perkj_webrtc
Created Revert of Removed unused cricket::VideoCapturer methods
4 years, 10 months ago (2016-02-26 10:53:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1740963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1740963002/1
4 years, 10 months ago (2016-02-26 10:54:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 10:54:42 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 10:54:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74622e061320d9fab4388c260b2d806de4b34e2f
Cr-Commit-Position: refs/heads/master@{#11777}

Powered by Google App Engine