Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1740873003: Reland "Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies." (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, video-team_agora.io, hlundin-webrtc, yujie_mao (webrtc), Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, mflodman, peah-webrtc, minyue-webrtc, the sun, pbos-webrtc, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies." This is a reland of https://codereview.webrtc.org/1737593002/ minus the added missing headers in webrtc/{BUILD.gn,webrtc.gyp} and webrtc/common.gyp that breaks GN in Chromium since it's using the --check flag (which we should support). BUG=webrtc:4243, webrtc:5589 TESTED=Tried generating GN files with --check in a Chromium checkout with this patch applied, successfully. TBR=pbos@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, tommi@webrtc.org Committed: https://crrev.com/7ffeab525c30124ac19bb96829aec0a7b7cd6641 Cr-Commit-Position: refs/heads/master@{#11794}

Patch Set 1 : Original patch set #

Patch Set 2 : Remove addition of missing headers to //webrtc:webrtc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -67 lines) Patch
M webrtc/api/remoteaudiosource.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/webrtcsession.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/audio/audio_sink.h View 1 chunk +0 lines, -53 lines 0 comments Download
M webrtc/audio/webrtc_audio.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A + webrtc/audio_sink.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/base/fakemediaengine.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/video/webrtc_video.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
kjellander_webrtc
Relanding this with just some of the changes removed, therefore TBRing previous reviewers.
4 years, 10 months ago (2016-02-26 21:42:19 UTC) #3
kjellander_webrtc
Committed patchset #2 (id:20001) manually as 7ffeab525c30124ac19bb96829aec0a7b7cd6641 (presubmit successful).
4 years, 10 months ago (2016-02-26 21:46:28 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 21:46:31 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ffeab525c30124ac19bb96829aec0a7b7cd6641
Cr-Commit-Position: refs/heads/master@{#11794}

Powered by Google App Engine
This is Rietveld 408576698