Simplify registration of RTP-header extensions.

Simplify registration of RTP-header extensions.

Removes per-extension functions in ViEChannel/ViEReceiver and instead
register extensions directly on the RTP module by mapping extension
string to RTP-header-extension type.

BUG=webrtc:5494
R=danilchap@webrtc.org, stefan@webrtc.org

Committed: https://crrev.com/9c01725e3742a2ccfdb525a2e0af80199b2ada55
Cr-Commit-Position: refs/heads/master@{#11786}

[pbos-webrtc, 2016-02-26 13:26:16]

PTAL, danilchap@ for review, stefan@ for owners.

[pbos-webrtc, 2016-02-26 13:26:23]

Description was changed from

==========
Simplify registration of RTP-header extensions.

Removes per-extension functions in ViEChannel/ViEReceiver and instead
register extensions directly on the RTP module by mapping extension
string to RTP-header-extension type.

BUG=webrtc:5494
R=danilchap@webrtc.org,stefan@webrtc.org
==========

to

==========
Simplify registration of RTP-header extensions.

Removes per-extension functions in ViEChannel/ViEReceiver and instead
register extensions directly on the RTP module by mapping extension
string to RTP-header-extension type.

BUG=webrtc:5494
R=danilchap@webrtc.org, stefan@webrtc.org
==========

[danilchap, 2016-02-26 13:44:39]

On 2016/02/26 13:26:16, pbos-webrtc wrote:
> PTAL, danilchap@ for review, stefan@ for owners.

This CL slightly misaligned with my plans for rtp header extension:
would like to drop RTPExtensionType to avoid multiply places for switch(all
extensions).
Based on your CL I made a quick CL to tell that I would like to push
switch(extension name) inside RtpRtcp module:
https://codereview.webrtc.org/1743543003/  Want to incorporate that in yours?


P.S. My current view on future header extension/packet class is here:
https://codereview.webrtc.org/1739273002/

[pbos-webrtc, 2016-02-26 13:51:50]

On 2016/02/26 13:44:39, danilchap wrote:
> On 2016/02/26 13:26:16, pbos-webrtc wrote:
> > PTAL, danilchap@ for review, stefan@ for owners.
> 
> This CL slightly misaligned with my plans for rtp header extension:
> would like to drop RTPExtensionType to avoid multiply places for switch(all
> extensions).
> Based on your CL I made a quick CL to tell that I would like to push
> switch(extension name) inside RtpRtcp module:
> https://codereview.webrtc.org/1743543003/  Want to incorporate that in yours?
> 
> 
> P.S. My current view on future header extension/packet class is here:
> https://codereview.webrtc.org/1739273002/

I still think your second change builds easier on top of this one, perhaps we
can land this one first?

[danilchap, 2016-02-26 14:11:16]

On 2016/02/26 13:51:50, pbos-webrtc wrote:
> On 2016/02/26 13:44:39, danilchap wrote:
> > On 2016/02/26 13:26:16, pbos-webrtc wrote:
> > > PTAL, danilchap@ for review, stefan@ for owners.
> > 
> > This CL slightly misaligned with my plans for rtp header extension:
> > would like to drop RTPExtensionType to avoid multiply places for switch(all
> > extensions).
> > Based on your CL I made a quick CL to tell that I would like to push
> > switch(extension name) inside RtpRtcp module:
> > https://codereview.webrtc.org/1743543003/  Want to incorporate that in
yours?
> > 
> > 
> > P.S. My current view on future header extension/packet class is here:
> > https://codereview.webrtc.org/1739273002/
> 
> I still think your second change builds easier on top of this one, perhaps we
> can land this one first?

lgtm

[stefan-webrtc, 2016-02-26 14:54:11]

https://codereview.webrtc.org/1740133002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1740133002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:234: StringToRtpExtensionType(extension),
id));
Should we no longer fail on trying to set audio extensions on video streams?

[pbos-webrtc, 2016-02-26 15:01:00]

DCHECK video extension availability

[pbos-webrtc, 2016-02-26 15:01:04]

PTAL

https://codereview.webrtc.org/1740133002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1740133002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:234: StringToRtpExtensionType(extension),
id));
On 2016/02/26 14:54:11, stefan-webrtc (holmer) wrote:
> Should we no longer fail on trying to set audio extensions on video streams?

Done.

[stefan-webrtc, 2016-02-26 15:19:18]

lgtm

https://codereview.webrtc.org/1740133002/diff/20001/webrtc/video/vie_receiver.cc
File webrtc/video/vie_receiver.cc (right):

https://codereview.webrtc.org/1740133002/diff/20001/webrtc/video/vie_receiver...
webrtc/video/vie_receiver.cc:159: StringToRtpExtensionType(extension), id));
Verify that this is a valid video extension.

[stefan-webrtc, 2016-02-26 15:19:19]

lgtm

[pbos-webrtc, 2016-02-26 15:20:14]

add dcheck

[pbos-webrtc, 2016-02-26 15:20:48]

https://codereview.webrtc.org/1740133002/diff/20001/webrtc/video/vie_receiver.cc
File webrtc/video/vie_receiver.cc (right):

https://codereview.webrtc.org/1740133002/diff/20001/webrtc/video/vie_receiver...
webrtc/video/vie_receiver.cc:159: StringToRtpExtensionType(extension), id));
On 2016/02/26 15:19:18, stefan-webrtc (holmer) wrote:
> Verify that this is a valid video extension.

Done.

[pbos-webrtc, 2016-02-26 15:22:28]

header

[pbos-webrtc, 2016-02-26 15:26:33]

Description was changed from

==========
Simplify registration of RTP-header extensions.

Removes per-extension functions in ViEChannel/ViEReceiver and instead
register extensions directly on the RTP module by mapping extension
string to RTP-header-extension type.

BUG=webrtc:5494
R=danilchap@webrtc.org, stefan@webrtc.org
==========

to

==========
Simplify registration of RTP-header extensions.

Removes per-extension functions in ViEChannel/ViEReceiver and instead
register extensions directly on the RTP module by mapping extension
string to RTP-header-extension type.

BUG=webrtc:5494
R=danilchap@webrtc.org, stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/9c01725e3742a2ccfdb525a2e...
==========

[commit-bot: I haz the power, 2016-02-26 15:26:33]

Description was changed from

==========
Simplify registration of RTP-header extensions.

Removes per-extension functions in ViEChannel/ViEReceiver and instead
register extensions directly on the RTP module by mapping extension
string to RTP-header-extension type.

BUG=webrtc:5494
R=danilchap@webrtc.org, stefan@webrtc.org
==========

to

==========
Simplify registration of RTP-header extensions.

Removes per-extension functions in ViEChannel/ViEReceiver and instead
register extensions directly on the RTP module by mapping extension
string to RTP-header-extension type.

BUG=webrtc:5494
R=danilchap@webrtc.org, stefan@webrtc.org

Committed: https://crrev.com/9c01725e3742a2ccfdb525a2e0af80199b2ada55
Cr-Commit-Position: refs/heads/master@{#11786}
==========

[commit-bot: I haz the power, 2016-02-26 15:26:34]

Patchset 4 (id:??) landed as
https://crrev.com/9c01725e3742a2ccfdb525a2e0af80199b2ada55
Cr-Commit-Position: refs/heads/master@{#11786}

[pbos-webrtc, 2016-02-26 15:26:34]

Committed patchset #4 (id:60001) manually as
9c01725e3742a2ccfdb525a2e0af80199b2ada55 (presubmit successful).