Remove add/removal of ViEReceiver RTP modules.

Remove add/removal of ViEReceiver RTP modules.

Since all possible modules are known on Init we don't need to add/remove
them in runtime.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed: https://crrev.com/4fa7ecad128f6406c71380d784b0de5d883da816
Cr-Commit-Position: refs/heads/master@{#11843}

[pbos-webrtc, 2016-02-26 15:41:14]

PTAL

[stefan-webrtc, 2016-02-29 09:15:04]

https://codereview.webrtc.org/1739893005/diff/1/webrtc/video/vie_receiver.cc
File webrtc/video/vie_receiver.cc (right):

https://codereview.webrtc.org/1739893005/diff/1/webrtc/video/vie_receiver.cc#...
webrtc/video/vie_receiver.cc:321: size_t rtcp_packet_length) {
DCHECK or CHECK

https://codereview.webrtc.org/1739893005/diff/1/webrtc/video/vie_receiver.cc#...
webrtc/video/vie_receiver.cc:330: // Deliver to simulcast modules first, then
base one.
Do you know why? Seems like it would be cleaner to just loop over the modules
and deliver rtcp to all of them.

[pbos-webrtc, 2016-02-29 09:58:55]

DCHECK and don't special-case base module

[pbos-webrtc, 2016-02-29 09:58:57]

ptal

https://codereview.webrtc.org/1739893005/diff/1/webrtc/video/vie_receiver.cc
File webrtc/video/vie_receiver.cc (right):

https://codereview.webrtc.org/1739893005/diff/1/webrtc/video/vie_receiver.cc#...
webrtc/video/vie_receiver.cc:321: size_t rtcp_packet_length) {
On 2016/02/29 09:15:04, stefan-webrtc (holmer) wrote:
> DCHECK or CHECK

Done.

https://codereview.webrtc.org/1739893005/diff/1/webrtc/video/vie_receiver.cc#...
webrtc/video/vie_receiver.cc:330: // Deliver to simulcast modules first, then
base one.
On 2016/02/29 09:15:04, stefan-webrtc (holmer) wrote:
> Do you know why? Seems like it would be cleaner to just loop over the modules
> and deliver rtcp to all of them.

Done.

[pbos-webrtc, 2016-02-29 10:00:07]

move comment

[stefan-webrtc, 2016-03-02 13:35:41]

lgtm

[pbos-webrtc, 2016-03-02 14:06:08]

Description was changed from

==========
Remove add/removal of ViEReceiver RTP modules.

Since all possible modules are known on Init we don't need to add/remove
them in runtime.

BUG=webrtc:5494
R=stefan@webrtc.org
==========

to

==========
Remove add/removal of ViEReceiver RTP modules.

Since all possible modules are known on Init we don't need to add/remove
them in runtime.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/4fa7ecad128f6406c71380d78...
==========

[pbos-webrtc, 2016-03-02 14:06:09]

Committed patchset #3 (id:40001) manually as
4fa7ecad128f6406c71380d784b0de5d883da816 (presubmit successful).

[commit-bot: I haz the power, 2016-03-02 14:06:10]

Description was changed from

==========
Remove add/removal of ViEReceiver RTP modules.

Since all possible modules are known on Init we don't need to add/remove
them in runtime.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/4fa7ecad128f6406c71380d78...
==========

to

==========
Remove add/removal of ViEReceiver RTP modules.

Since all possible modules are known on Init we don't need to add/remove
them in runtime.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed: https://crrev.com/4fa7ecad128f6406c71380d784b0de5d883da816
Cr-Commit-Position: refs/heads/master@{#11843}
==========

[commit-bot: I haz the power, 2016-03-02 14:06:11]

Patchset 3 (id:??) landed as
https://crrev.com/4fa7ecad128f6406c71380d784b0de5d883da816
Cr-Commit-Position: refs/heads/master@{#11843}