Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issue 1739893004: Remove incorrect reinterpret_cast from const. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 9 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove incorrect reinterpret_cast from const. Code still compiles in Chromium with a proper const float* variable so it is expected to address the issue. BUG=chromium:589951 TBR=peah@webrtc.org Committed: https://crrev.com/0e40f7cf87b5094df143a50a8c8c9a567f852981 Cr-Commit-Position: refs/heads/master@{#11772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core_mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL
4 years, 10 months ago (2016-02-25 21:36:21 UTC) #1
pbos-webrtc
Committed patchset #1 (id:1) manually as 0e40f7cf87b5094df143a50a8c8c9a567f852981 (presubmit successful).
4 years, 10 months ago (2016-02-25 21:37:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0e40f7cf87b5094df143a50a8c8c9a567f852981 Cr-Commit-Position: refs/heads/master@{#11772}
4 years, 10 months ago (2016-02-25 21:37:10 UTC) #5
peah-webrtc
4 years, 9 months ago (2016-02-29 07:14:57 UTC) #6
Message was sent while issue was closed.
On 2016/02/25 21:37:10, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/0e40f7cf87b5094df143a50a8c8c9a567f852981
> Cr-Commit-Position: refs/heads/master@{#11772}

Great! Thanks for fixing this!!! 
lgtm

Powered by Google App Engine
This is Rietveld 408576698