Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1739893003:
Fix lowPowerModeEnabled crash on iOS8 (Closed)
|
Created:
4 years, 10 months ago by tkchin_webrtc Modified:
4 years, 9 months ago Reviewers:
henrika_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix lowPowerModeEnabled crash on iOS8
BUG=webrtc::5564
Committed: https://crrev.com/fc59c4425ee0aa871650b96c52b3898e7216a362
Cr-Commit-Position: refs/heads/master@{#11774}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 14 (6 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Fix lowPowerModeEnabled crash on iOS8 BUG=webrtc::5564 ========== to ========== Fix lowPowerModeEnabled crash on iOS8 BUG=webrtc::5564 ==========
tkchin@webrtc.org changed reviewers: + henrika@webrtc.org
Thanks for finding my mistake. Kind of odd that the stack trace pointed at the DecodingThread. LGTM
https://codereview.webrtc.org/1739893003/diff/20001/webrtc/modules/utility/so... File webrtc/modules/utility/source/helpers_ios.mm (right): https://codereview.webrtc.org/1739893003/diff/20001/webrtc/modules/utility/so... webrtc/modules/utility/source/helpers_ios.mm:175: if ([info respondsToSelector:@selector(lowPoweredModeEnabled)]) { Just learning. Is this the way to go to check for method support? On Android, we usually make a more explicit check by asking for the OS version. Like this one better.
The CQ bit was checked by henrika@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739893003/20001
Message was sent while issue was closed.
Description was changed from ========== Fix lowPowerModeEnabled crash on iOS8 BUG=webrtc::5564 ========== to ========== Fix lowPowerModeEnabled crash on iOS8 BUG=webrtc::5564 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix lowPowerModeEnabled crash on iOS8 BUG=webrtc::5564 ========== to ========== Fix lowPowerModeEnabled crash on iOS8 BUG=webrtc::5564 Committed: https://crrev.com/fc59c4425ee0aa871650b96c52b3898e7216a362 Cr-Commit-Position: refs/heads/master@{#11774} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fc59c4425ee0aa871650b96c52b3898e7216a362 Cr-Commit-Position: refs/heads/master@{#11774}
Message was sent while issue was closed.
On 2016/02/26 08:24:24, henrika_webrtc wrote: > https://codereview.webrtc.org/1739893003/diff/20001/webrtc/modules/utility/so... > File webrtc/modules/utility/source/helpers_ios.mm (right): > > https://codereview.webrtc.org/1739893003/diff/20001/webrtc/modules/utility/so... > webrtc/modules/utility/source/helpers_ios.mm:175: if ([info > respondsToSelector:@selector(lowPoweredModeEnabled)]) { > Just learning. Is this the way to go to check for method support? On Android, we > usually make a more explicit check by asking for the OS version. Like this one > better. See: https://developer.apple.com/library/ios/documentation/DeveloperTools/Conceptu... Either works. Now that I think about it again, it is probably better to guard with macro, and then perform OS check because that is likely faster than checking selector since it is cached. so e.g. #if defined(__IPHONE_9_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_9_0 if (RTCIsIOS9OrGreater()) { .. do work } #endif
Message was sent while issue was closed.
Filed https://codereview.webrtc.org/1746023002/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
