|
Revert of Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies. (patchset #2 id:40001 of https://codereview.webrtc.org/1737593002/ )
Reason for revert:
Breaks GN in chromium.
Original issue's description:
> Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.
>
> webrtc/audio/audio_sink.h is used by voice engine, but webrtc/audio is
> depending on voice engine, resulting in a cyclic dependency (which we
> don't detect since we have that check turned off, see webrtc:4243).
>
> BUG= webrtc:4243, webrtc:5589
> R=pbos@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org
> TBR=tommi@webrtc.org
>
> Committed: https://crrev.com/99b345c4e50c59a776c56949c17da3f50992f1a2
> Cr-Commit-Position: refs/heads/master@{#11766}
TBR=solenberg@webrtc.org,pbos@webrtc.org,perkj@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= webrtc:4243, webrtc:5589
Committed: https://crrev.com/7324eb9e62d1bd0a38c290ab36459a08e1f9b829
Cr-Commit-Position: refs/heads/master@{#11769}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+77 lines, -96 lines) |
Patch |
|
M |
webrtc/BUILD.gn
|
View
|
|
2 chunks |
+3 lines, -13 lines |
0 comments
|
Download
|
|
M |
webrtc/api/remoteaudiosource.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/api/webrtcsession.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/audio/audio_receive_stream.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
A |
webrtc/audio/audio_sink.h
|
View
|
|
1 chunk |
+53 lines, -0 lines |
0 comments
|
Download
|
|
M |
webrtc/audio/webrtc_audio.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
D |
webrtc/audio_sink.h
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
|
M |
webrtc/base/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
webrtc/base/base.gyp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
webrtc/common.gyp
|
View
|
|
1 chunk |
+1 line, -9 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/fakemediaengine.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/media/engine/fakewebrtccall.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/media/engine/webrtcvoiceengine.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/pc/channel.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/pc/channel.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/video/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
webrtc/video/webrtc_video.gypi
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
webrtc/voice_engine/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
webrtc/voice_engine/channel.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/voice_engine/channel_proxy.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/voice_engine/voice_engine.gyp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
webrtc/webrtc.gyp
|
View
|
|
1 chunk |
+9 lines, -3 lines |
0 comments
|
Download
|
Total messages: 6 (1 generated)
|