Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1739753002:
Fix ubsan warning in byteio_unittest (Closed)
|
Created:
4 years, 10 months ago by sprang_webrtc Modified:
4 years, 10 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix ubsan warning in byteio_unittest
BUG=webrtc:5490
Committed: https://crrev.com/c63f79a0a56aa255c9f426f3cf1dc2c0d9082261
Cr-Commit-Position: refs/heads/master@{#11782}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Actually preserve func #Patch Set 3 : Undo "fix" and add comments #
Total comments: 2
Patch Set 4 : Fixed nit #Messages
Total messages: 20 (8 generated)
sprang@webrtc.org changed reviewers: + stefan@webrtc.org
The CQ bit was checked by sprang@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739753002/20001
https://codereview.webrtc.org/1739753002/diff/1/webrtc/modules/rtp_rtcp/sourc... File webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc (right): https://codereview.webrtc.org/1739753002/diff/1/webrtc/modules/rtp_rtcp/sourc... webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:38: } Add a comment about what the mask you are constructing looks like.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Exceeded global retry quota
https://codereview.webrtc.org/1739753002/diff/1/webrtc/modules/rtp_rtcp/sourc... File webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc (right): https://codereview.webrtc.org/1739753002/diff/1/webrtc/modules/rtp_rtcp/sourc... webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:38: } On 2016/02/26 09:30:34, stefan-webrtc (holmer) wrote: > Add a comment about what the mask you are constructing looks like. Done.
lgtm https://codereview.webrtc.org/1739753002/diff/40001/webrtc/modules/rtp_rtcp/s... File webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc (right): https://codereview.webrtc.org/1739753002/diff/40001/webrtc/modules/rtp_rtcp/s... webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:41: // For the last example (marked * above), we the number needs to be sign "the number needs to..."
https://codereview.webrtc.org/1739753002/diff/40001/webrtc/modules/rtp_rtcp/s... File webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc (right): https://codereview.webrtc.org/1739753002/diff/40001/webrtc/modules/rtp_rtcp/s... webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:41: // For the last example (marked * above), we the number needs to be sign On 2016/02/26 10:11:19, stefan-webrtc (holmer) wrote: > "the number needs to..." Done.
The CQ bit was checked by sprang@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/1739753002/#ps60001 (title: "Fixed nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739753002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739753002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sprang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739753002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739753002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Fix ubsan warning in byteio_unittest BUG=webrtc:5490 ========== to ========== Fix ubsan warning in byteio_unittest BUG=webrtc:5490 Committed: https://crrev.com/c63f79a0a56aa255c9f426f3cf1dc2c0d9082261 Cr-Commit-Position: refs/heads/master@{#11782} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/c63f79a0a56aa255c9f426f3cf1dc2c0d9082261 Cr-Commit-Position: refs/heads/master@{#11782} |
