Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1739713002: Build SharedExclusiveLock in Chromium. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Build SharedExclusiveLock in Chromium. Partially un-breaks the Chromium FYI build. TBR=jbauch@webrtc.org, tommi@webrtc.org BUG= Committed: https://crrev.com/a5d8e4eef58574ddb4c4c818de71491a52887f45 Cr-Commit-Position: refs/heads/master@{#11765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pbos-webrtc
messagequeue.cc now depends on sharedexclusivelock.{h,cc}, pushing this.
4 years, 10 months ago (2016-02-25 13:53:27 UTC) #1
pbos-webrtc
Committed patchset #1 (id:1) manually as a5d8e4eef58574ddb4c4c818de71491a52887f45 (presubmit successful).
4 years, 10 months ago (2016-02-25 13:54:26 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a5d8e4eef58574ddb4c4c818de71491a52887f45 Cr-Commit-Position: refs/heads/master@{#11765}
4 years, 10 months ago (2016-02-25 13:54:29 UTC) #5
joachim
On 2016/02/25 13:53:27, pbos-webrtc wrote: > messagequeue.cc now depends on sharedexclusivelock.{h,cc}, pushing this. lgtm, thanks!
4 years, 10 months ago (2016-02-25 13:58:24 UTC) #6
tommi (sloooow) - chröme
4 years, 10 months ago (2016-02-26 11:10:04 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698