Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1739283002: Remove add/removal of RTP modules in PacketRouter. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove add/removal of RTP modules in PacketRouter. PacketRouter still relies on SendingMedia() which is set to false for the disabled modules. BUG=webrtc:5494 R=stefan@webrtc.org Committed: https://crrev.com/f8136bac63c04fab29e8500fec6b7fec59ea0727 Cr-Commit-Position: refs/heads/master@{#11788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -20 lines) Patch
M webrtc/video/vie_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/vie_channel.cc View 5 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL
4 years, 10 months ago (2016-02-26 15:32:57 UTC) #1
stefan-webrtc
lgtm
4 years, 10 months ago (2016-02-26 15:35:20 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as f8136bac63c04fab29e8500fec6b7fec59ea0727 (presubmit successful).
4 years, 10 months ago (2016-02-26 15:37:27 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 15:37:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8136bac63c04fab29e8500fec6b7fec59ea0727
Cr-Commit-Position: refs/heads/master@{#11788}

Powered by Google App Engine
This is Rietveld 408576698