Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 1739273002: [Draft] RtpPacket sketched. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase to use landed version of rtp::Packet Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/rtp_rtcp.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
index 50fb35e0e4fb17102cc0b639e805ca2c6d9f03a9..3bf45287bea5627e1502a56e2b7af89a7448ceb4 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
@@ -16,6 +16,7 @@
#include <utility>
#include <vector>
+#include "webrtc/call.h"
#include "webrtc/modules/include/module.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
#include "webrtc/modules/video_coding/include/video_coding_defines.h"
@@ -188,6 +189,11 @@ class RtpRtcp : public Module {
virtual int32_t DeregisterSendRtpHeaderExtension(RTPExtensionType type) = 0;
+ // TODO(danilchap): Make pure virtual in 3 months.
+ virtual bool RegisterRtpHeaderExtension(const std::string& type,
+ MediaType media,
+ uint8_t id);
+
/*
* get start timestamp
*/
@@ -362,12 +368,11 @@ class RtpRtcp : public Module {
*
* return -1 on failure else 0
*/
- virtual int32_t RemoteNTP(
- uint32_t *ReceivedNTPsecs,
- uint32_t *ReceivedNTPfrac,
- uint32_t *RTCPArrivalTimeSecs,
- uint32_t *RTCPArrivalTimeFrac,
- uint32_t *rtcp_timestamp) const = 0;
+ virtual int32_t RemoteNTP(uint32_t* ReceivedNTPsecs,
+ uint32_t* ReceivedNTPfrac,
+ uint32_t* RTCPArrivalTimeSecs,
+ uint32_t* RTCPArrivalTimeFrac,
+ uint32_t* rtcp_timestamp) const = 0;
/*
* AddMixedCNAME
@@ -548,14 +553,10 @@ class RtpRtcp : public Module {
*/
virtual void SetStorePacketsStatus(bool enable, uint16_t numberToStore) = 0;
- // Returns true if the module is configured to store packets.
- virtual bool StorePackets() const = 0;
-
// Called on receipt of RTCP report block from remote side.
virtual void RegisterRtcpStatisticsCallback(
RtcpStatisticsCallback* callback) = 0;
- virtual RtcpStatisticsCallback*
- GetRtcpStatisticsCallback() = 0;
+ virtual RtcpStatisticsCallback* GetRtcpStatisticsCallback() = 0;
// BWE feedback packets.
virtual bool SendFeedbackPacket(const rtcp::TransportFeedback& packet) = 0;
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/rtp_rtcp.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698