Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1739273002: [Draft] RtpPacket sketched. (Closed)

Created:
4 years, 9 months ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, philipel, terelius, sprang
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RtpPacket with different Rtp Header Extension manager drafted. Rtp Header Extensions managed by RtpPacketManager. Packet History rewritten to completely incorporate RtpPacket RtpSender partially make use of RtpPacket. deprecated in favor of Draft: https://codereview.webrtc.org/2217383002/ COMMIT=false BUG=webrtc:1994, webrtc:5261

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : rebase to use landed version of rtp::Packet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+815 lines, -964 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 1 2 3 4 5 4 chunks +12 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h View 1 2 3 4 5 5 chunks +5 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtp_header_extensions_manager.h View 1 2 3 4 5 1 chunk +77 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtp_header_extensions_manager.cc View 1 2 3 4 5 1 chunk +55 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 1 2 3 4 5 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.h View 1 2 3 4 5 4 chunks +19 lines, -34 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc View 1 2 3 4 5 8 chunks +68 lines, -164 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc View 1 2 3 4 5 2 chunks +85 lines, -176 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_to_send.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc View 1 2 3 4 5 8 chunks +11 lines, -18 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 2 3 4 5 3 chunks +5 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 2 3 4 5 3 chunks +20 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 2 3 4 5 12 chunks +38 lines, -28 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 2 3 4 5 25 chunks +208 lines, -292 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 1 2 3 4 5 11 chunks +56 lines, -67 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 2 3 4 5 19 chunks +72 lines, -66 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 1 2 3 4 5 2 chunks +4 lines, -14 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 2 3 4 5 10 chunks +65 lines, -62 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
danilchap
Description was changed from ========== RtpPacket with different Rtp Header Extension manager drafted. Rtp Header ...
4 years, 9 months ago (2016-02-29 11:36:37 UTC) #1
danilchap
Description was changed from ========== RtpPacket with different Rtp Header Extension manager drafted. Rtp Header ...
4 years, 4 months ago (2016-07-28 08:19:01 UTC) #2
danilchap
4 years, 4 months ago (2016-08-08 07:46:24 UTC) #3
Message was sent while issue was closed. 
Description was changed from

==========
RtpPacket with different Rtp Header Extension manager drafted.

Rtp Header Extensions managed by RtpPacketManager.

Packet History rewritten to completely incorporate RtpPacket
RtpSender partially make use of RtpPacket.


COMMIT=false
BUG=webrtc:1994, webrtc:5261
==========

to

==========
RtpPacket with different Rtp Header Extension manager drafted.

Rtp Header Extensions managed by RtpPacketManager.

Packet History rewritten to completely incorporate RtpPacket
RtpSender partially make use of RtpPacket.

deprecated in favor of Draft: https://codereview.webrtc.org/2217383002/


COMMIT=false
BUG=webrtc:1994, webrtc:5261
==========

Powered by Google App Engine
This is Rietveld 408576698