Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1738763002: Remove DCHECK on duplicate packets in RemoteEstimatorProxy. (Closed)

Created:
4 years, 10 months ago by stefan-webrtc
Modified:
4 years, 10 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove DCHECK on duplicate packets in RemoteEstimatorProxy. R=sprang@webrtc.org Committed: https://crrev.com/91c5b5650c7b86f8d6ab91fa61c4054a2e488ca1 Cr-Commit-Position: refs/heads/master@{#11760}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc View 1 chunk +3 lines, -1 line 1 comment Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
stefan-webrtc
4 years, 10 months ago (2016-02-25 09:48:28 UTC) #2
sprang_webrtc
lgtm https://codereview.webrtc.org/1738763002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc File webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc (right): https://codereview.webrtc.org/1738763002/diff/1/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc#newcode109 webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc:109: // We are only interested in the first ...
4 years, 10 months ago (2016-02-25 10:40:35 UTC) #3
stefan-webrtc
Committed patchset #1 (id:1) manually as 91c5b5650c7b86f8d6ab91fa61c4054a2e488ca1 (presubmit successful).
4 years, 10 months ago (2016-02-25 11:35:30 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 11:35:31 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/91c5b5650c7b86f8d6ab91fa61c4054a2e488ca1
Cr-Commit-Position: refs/heads/master@{#11760}

Powered by Google App Engine
This is Rietveld 408576698