Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1738123002: Java SurfaceTextureHelper: Remove support for external thread (Closed)

Created:
4 years, 9 months ago by magjed_webrtc
Modified:
4 years, 9 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Java SurfaceTextureHelper: Remove support for external thread Currently, VideoCapturerAndroid owns a dedicated tread, and SurfaceTextureHelper get this thread passed in the ctor. In VideoCapturerAndroid.dispose(), ownership of the thread is passed to SurfaceTextureHelper so that we can return directly instead of waiting for the last frame to return. This CL makes the SurfaceTextureHelper own the thread the whole time instead, and VideoCapturerAndroid calls getHandler() to get it instead. BUG=webrtc:5519 Committed: https://crrev.com/9e69dfdfd5f38cdbd335280fb158a6e2a11a65d6 Cr-Commit-Position: refs/heads/master@{#11790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -126 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java View 2 chunks +0 lines, -74 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/SurfaceTextureHelper.java View 6 chunks +23 lines, -44 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
magjed_webrtc
perkj - Please take a look.
4 years, 9 months ago (2016-02-26 11:28:33 UTC) #3
perkj_webrtc
lgtm
4 years, 9 months ago (2016-02-26 12:07:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738123002/1
4 years, 9 months ago (2016-02-26 13:31:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-26 15:45:48 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 15:45:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e69dfdfd5f38cdbd335280fb158a6e2a11a65d6
Cr-Commit-Position: refs/heads/master@{#11790}

Powered by Google App Engine
This is Rietveld 408576698