Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

webrtc/audio/audio_sink.h is used by voice engine, but webrtc/audio is
depending on voice engine, resulting in a cyclic dependency (which we
don't detect since we have that check turned off, see webrtc:4243).

BUG=webrtc:4243, webrtc:5589
R=pbos@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org
TBR=tommi@webrtc.org

Committed: https://crrev.com/99b345c4e50c59a776c56949c17da3f50992f1a2
Cr-Commit-Position: refs/heads/master@{#11766}

[kjellander_webrtc, 2016-02-25 10:55:16]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-02-25 10:55:31]

Description was changed from

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

BUG=webrtc:5589

Add missing dependencies for headers
==========

to

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

BUG=webrtc:5589
==========

[kjellander_webrtc, 2016-02-25 11:08:48]

kjellander@webrtc.org changed reviewers:
+ pbos@webrtc.org, solenberg@webrtc.org

[kjellander_webrtc, 2016-02-25 11:10:19]

Description was changed from

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

BUG=webrtc:5589
==========

to

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

BUG=webrtc:4243, webrtc:5589
==========

[kjellander_webrtc, 2016-02-25 11:11:32]

kjellander@webrtc.org changed reviewers:
+ perkj@webrtc.org

[kjellander_webrtc, 2016-02-25 11:12:06]

solenberg,pbos: main review
perkj: rubberstamp for webrtc/api, webrtc/base, webrtc/pc

https://codereview.webrtc.org/1737593002/diff/20001/webrtc/BUILD.gn
File webrtc/BUILD.gn (left):

https://codereview.webrtc.org/1737593002/diff/20001/webrtc/BUILD.gn#oldcode171
webrtc/BUILD.gn:171: "config.h",
moved to common.gyp:webrtc_common since they only depend on other headers in
there (of each other).

https://codereview.webrtc.org/1737593002/diff/20001/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/1737593002/diff/20001/webrtc/BUILD.gn#newcode170
webrtc/BUILD.gn:170: "audio_send_stream.h",
These were missing from any .gyp* file.

https://codereview.webrtc.org/1737593002/diff/20001/webrtc/BUILD.gn#newcode231
webrtc/BUILD.gn:231: "audio_receive_stream.h",
Maybe it's confusing to have audio_recieve_stream.h here and audio_send_stream.h
in the 'webrtc' target? 
I based it only on what they include. This one can be here since it only
includes headers in this target. The other one can't since it includes
"webrtc/base/scoped_ptr.h" and 
"webrtc/modules/audio_coding/codecs/audio_encoder.h"

https://codereview.webrtc.org/1737593002/diff/20001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/1737593002/diff/20001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:129: "format_macros.h",
This was missing. I haven't checked the rest but I want to keep this CL
reasonably small so I will iterate on that more in future CLs.

[perkj_webrtc, 2016-02-25 11:30:28]

why are we moving files to the root folder?

[kjellander_webrtc, 2016-02-25 11:41:24]

Description was changed from

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

BUG=webrtc:4243, webrtc:5589
==========

to

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

webrtc/audio/audio_sink.h is used by voice engine, but webrtc/audio is
depending on voice engine, resulting in a cyclic dependency (which we
don't detect since we have that check turned off, see webrtc:4243).

BUG=webrtc:4243, webrtc:5589
==========

[kjellander_webrtc, 2016-02-25 11:42:49]

On 2016/02/25 11:30:28, perkj_webrtc wrote:
> why are we moving files to the root folder?

There are several similar headers in the root folder so I'm following that
approach. This particular header is used both by voice engine and webrtc/audio,
but webrtc/audio is
depending on voice engine as well, resulting in a cyclic dependency (which we
don't detect since we have that check turned off, see webrtc:4243). I added this
to the CL description.

I'm trying to clean up some of such errors related to the referenced bugs.

[pbos-webrtc, 2016-02-25 13:02:34]

On 2016/02/25 11:42:49, kjellander (webrtc) wrote:
> On 2016/02/25 11:30:28, perkj_webrtc wrote:
> > why are we moving files to the root folder?
> 
> There are several similar headers in the root folder so I'm following that
> approach. This particular header is used both by voice engine and
webrtc/audio,
> but webrtc/audio is
> depending on voice engine as well, resulting in a cyclic dependency (which we
> don't detect since we have that check turned off, see webrtc:4243). I added
this
> to the CL description.
> 
> I'm trying to clean up some of such errors related to the referenced bugs.

Is it enough to remove that file from the target?

[kjellander_webrtc, 2016-02-25 13:26:01]

On 2016/02/25 13:02:34, pbos-webrtc wrote:
> On 2016/02/25 11:42:49, kjellander (webrtc) wrote:
> > On 2016/02/25 11:30:28, perkj_webrtc wrote:
> > > why are we moving files to the root folder?
> > 
> > There are several similar headers in the root folder so I'm following that
> > approach. This particular header is used both by voice engine and
> webrtc/audio,
> > but webrtc/audio is
> > depending on voice engine as well, resulting in a cyclic dependency (which
we
> > don't detect since we have that check turned off, see webrtc:4243). I added
> this
> > to the CL description.
> > 
> > I'm trying to clean up some of such errors related to the referenced bugs.
> 
> Is it enough to remove that file from the target?

That's possible, but all sources (including headers) should be listed in GYP/GN
targets, so that's not the way to go.

[the sun, 2016-02-25 13:54:32]

LGTM for moving audio_sink.h. Since it is referenced in
webrtc/audio_receive_stream.h, this is where it should have been placed
initially.

[pbos-webrtc, 2016-02-25 13:58:15]

lgtm

[perkj_webrtc, 2016-02-25 14:04:54]

Putting files in the root folder means that only root owners can approve changes
to them. 
I think that is the wrong path to go.

[the sun, 2016-02-25 14:08:42]

On 2016/02/25 14:04:54, perkj_webrtc wrote:
> Putting files in the root folder means that only root owners can approve
changes
> to them. 
> I think that is the wrong path to go.

Agree that keeping files in the root folder is problematic. However this CL
supports the current structure. 

I think the best course of action is file a bug and raise the issue that ALL the
source files in the root should possibly live elsewhere.

[perkj_webrtc, 2016-02-25 14:08:59]

On 2016/02/25 14:04:54, perkj_webrtc wrote:
> Putting files in the root folder means that only root owners can approve
changes
> to them. 
> I think that is the wrong path to go.

Now that you have heard my objection- lgtm for this since all files that already
is there should probably be moved at once.

[kjellander_webrtc, 2016-02-25 14:09:57]

On 2016/02/25 14:04:54, perkj_webrtc wrote:
> Putting files in the root folder means that only root owners can approve
changes
> to them. 
> I think that is the wrong path to go.

I tend to agree, although that can be adressed with an OWNERS file in webrtc/
though (not necessarily the root).
Also, this CL doesn't really change that much considering there are already 18
header files in there.
In addition to that, these are APIs that should rarely change, so involving a
root owner is not that cumbersome.

I suggest we keep the larger discussion separate from this review.

[kjellander_webrtc, 2016-02-25 14:11:07]

On 2016/02/25 14:08:59, perkj_webrtc wrote:
> On 2016/02/25 14:04:54, perkj_webrtc wrote:
> > Putting files in the root folder means that only root owners can approve
> changes
> > to them. 
> > I think that is the wrong path to go.
> 
> Now that you have heard my objection- lgtm for this since all files that
already
> is there should probably be moved at once.

Thanks (I replied before I saw this).

[kjellander_webrtc, 2016-02-25 14:12:09]

Description was changed from

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

webrtc/audio/audio_sink.h is used by voice engine, but webrtc/audio is
depending on voice engine, resulting in a cyclic dependency (which we
don't detect since we have that check turned off, see webrtc:4243).

BUG=webrtc:4243, webrtc:5589
==========

to

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

webrtc/audio/audio_sink.h is used by voice engine, but webrtc/audio is
depending on voice engine, resulting in a cyclic dependency (which we
don't detect since we have that check turned off, see webrtc:4243).

BUG=webrtc:4243, webrtc:5589
TBR=tommi@webrtc.org
==========

[kjellander_webrtc, 2016-02-25 14:12:09]

kjellander@webrtc.org changed reviewers:
+ tommi@webrtc.org

[kjellander_webrtc, 2016-02-25 14:12:32]

TBR tommi for root owners approval for webrtc/audio_sink.h ;-)

[kjellander_webrtc, 2016-02-25 14:12:54]

Description was changed from

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

webrtc/audio/audio_sink.h is used by voice engine, but webrtc/audio is
depending on voice engine, resulting in a cyclic dependency (which we
don't detect since we have that check turned off, see webrtc:4243).

BUG=webrtc:4243, webrtc:5589
TBR=tommi@webrtc.org
==========

to

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

webrtc/audio/audio_sink.h is used by voice engine, but webrtc/audio is
depending on voice engine, resulting in a cyclic dependency (which we
don't detect since we have that check turned off, see webrtc:4243).

BUG=webrtc:4243, webrtc:5589
R=pbos@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org
TBR=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/99b345c4e50c59a776c56949c...
==========

[commit-bot: I haz the power, 2016-02-25 14:12:55]

Description was changed from

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

webrtc/audio/audio_sink.h is used by voice engine, but webrtc/audio is
depending on voice engine, resulting in a cyclic dependency (which we
don't detect since we have that check turned off, see webrtc:4243).

BUG=webrtc:4243, webrtc:5589
TBR=tommi@webrtc.org
==========

to

==========
Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.

webrtc/audio/audio_sink.h is used by voice engine, but webrtc/audio is
depending on voice engine, resulting in a cyclic dependency (which we
don't detect since we have that check turned off, see webrtc:4243).

BUG=webrtc:4243, webrtc:5589
R=pbos@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org
TBR=tommi@webrtc.org

Committed: https://crrev.com/99b345c4e50c59a776c56949c17da3f50992f1a2
Cr-Commit-Position: refs/heads/master@{#11766}
==========

[commit-bot: I haz the power, 2016-02-25 14:12:56]

Patchset 2 (id:??) landed as
https://crrev.com/99b345c4e50c59a776c56949c17da3f50992f1a2
Cr-Commit-Position: refs/heads/master@{#11766}

[kjellander_webrtc, 2016-02-25 14:12:56]

Committed patchset #2 (id:40001) manually as
99b345c4e50c59a776c56949c17da3f50992f1a2 (presubmit successful).

[kjellander_webrtc, 2016-02-25 16:36:16]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.webrtc.org/1739783002/ by kjellander@webrtc.org.

The reason for reverting is: Breaks GN in chromium..