Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1737053006: Don't allocate buffers for listening sockets. (Closed)

Created:
4 years, 10 months ago by joachim
Modified:
4 years, 10 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't allocate buffers for listening sockets. Listening sockets will not read/write directly, so they don't need buffers. BUG= Committed: https://crrev.com/3c1657658d017cc0b265d032248502fd46825a8a Cr-Commit-Position: refs/heads/master@{#11791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M webrtc/base/asynctcpsocket.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/base/asynctcpsocket.cc View 9 chunks +25 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joachim
Ptal, this reduces memory usage and is especially helpful for very-low memory environments. Also changed ...
4 years, 10 months ago (2016-02-26 15:29:54 UTC) #2
tommi
lgtm
4 years, 10 months ago (2016-02-26 15:42:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737053006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737053006/1
4 years, 10 months ago (2016-02-26 15:42:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 17:31:35 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 17:31:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c1657658d017cc0b265d032248502fd46825a8a
Cr-Commit-Position: refs/heads/master@{#11791}

Powered by Google App Engine
This is Rietveld 408576698