webrtc/modules/bitrate_controller/bitrate_controller_impl.cc - Issue 1737013002: Reland of move ignored return code from modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/bitrate_controller_impl.cc

Issue 1737013002: Reland of move ignored return code from modules. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/bitrate_controller/bitrate_controller_impl.h ('k') | webrtc/modules/bitrate_controller/include/mock/mock_bitrate_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/bitrate_controller_impl.cc

diff --git a/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc b/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc

index 72a5ff510ddc28d459d0286d2cd2a89b3ee3ca0d..bf608789d5d7462110f9c6e434d4def02a09c79e 100644

--- a/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc

+++ b/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc

@@ -162,16 +162,15 @@

kBitrateControllerUpdateIntervalMs - time_since_update_ms, 0);

}

-int32_t BitrateControllerImpl::Process() {

+void BitrateControllerImpl::Process() {

if (TimeUntilNextProcess() > 0)

- return 0;

+ return;

{

rtc::CritScope cs(&critsect_);

bandwidth_estimation_.UpdateEstimate(clock_->TimeInMilliseconds());

}

MaybeTriggerOnNetworkChanged();

last_bitrate_update_ms_ = clock_->TimeInMilliseconds();

- return 0;

}

void BitrateControllerImpl::OnReceivedRtcpReceiverReport(