Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc

Issue 1737013002: Reland of move ignored return code from modules. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc
index c1a498806b887abc42ef8aae4781e9ad686681d7..7d39b03666a6f61b61e393dceab1deae6c998f07 100644
--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc
+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc
@@ -93,10 +93,10 @@
IncomingPacket(0, 1000, clock_.TimeInMilliseconds(), 0, 0, true);
clock_.AdvanceTimeMilliseconds(kStreamTimeOutMs + 1);
// Trigger timeout.
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
clock_.AdvanceTimeMilliseconds(kProcessIntervalMs);
// This shouldn't crash.
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
}
TEST_F(RemoteBitrateEstimatorAbsSendTimeTest, TestProbeDetection) {
@@ -118,7 +118,7 @@
true);
}
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
EXPECT_TRUE(bitrate_observer_->updated());
EXPECT_GT(bitrate_observer_->latest_bitrate(), 1500000u);
}
@@ -140,7 +140,7 @@
false);
}
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
EXPECT_TRUE(bitrate_observer_->updated());
EXPECT_GT(bitrate_observer_->latest_bitrate(), 800000u);
}
@@ -171,7 +171,7 @@
AbsSendTime(send_time_ms, 1000), true);
}
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
EXPECT_TRUE(bitrate_observer_->updated());
EXPECT_NEAR(bitrate_observer_->latest_bitrate(), 800000u, 10000);
}
@@ -191,7 +191,7 @@
AbsSendTime(send_time_ms, 1000), true);
}
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
EXPECT_TRUE(bitrate_observer_->updated());
EXPECT_GT(bitrate_observer_->latest_bitrate(), 800000u);
}
@@ -210,7 +210,7 @@
AbsSendTime(send_time_ms, 1000), true);
}
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
EXPECT_FALSE(bitrate_observer_->updated());
}
@@ -228,7 +228,7 @@
AbsSendTime(send_time_ms, 1000), true);
}
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
EXPECT_TRUE(bitrate_observer_->updated());
EXPECT_NEAR(bitrate_observer_->latest_bitrate(), 1140000, 10000);
}
@@ -248,7 +248,7 @@
AbsSendTime(send_time_ms, 1000), true);
}
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
EXPECT_TRUE(bitrate_observer_->updated());
EXPECT_NEAR(bitrate_observer_->latest_bitrate(), 4000000u, 10000);
}
@@ -265,7 +265,7 @@
true);
}
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
EXPECT_FALSE(bitrate_observer_->updated());
// Followed by a probe with 1000 bytes packets, should be detected as a
@@ -280,7 +280,7 @@
// Wait long enough so that we can call Process again.
clock_.AdvanceTimeMilliseconds(1000);
- EXPECT_EQ(0, bitrate_estimator_->Process());
+ bitrate_estimator_->Process();
EXPECT_TRUE(bitrate_observer_->updated());
EXPECT_NEAR(bitrate_observer_->latest_bitrate(), 800000u, 10000);
}

Powered by Google App Engine
This is Rietveld 408576698