webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc - Issue 1737013002: Reland of move ignored return code from modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

Issue 1737013002: Reland of move ignored return code from modules. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h ('k') | webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

index 2b740434c1abbdae940167e81ce5d41de950079b..9a1bbc16b55aafc0a062796c077fb94990f27a27 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

@@ -118,16 +118,15 @@

}

-int32_t RemoteBitrateEstimatorSingleStream::Process() {

+void RemoteBitrateEstimatorSingleStream::Process() {

if (TimeUntilNextProcess() > 0) {

- return 0;

+ return;

}

{

CriticalSectionScoped cs(crit_sect_.get());

UpdateEstimate(clock_->TimeInMilliseconds());

}

last_process_time_ = clock_->TimeInMilliseconds();

- return 0;

}

int64_t RemoteBitrateEstimatorSingleStream::TimeUntilNextProcess() {