Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: webrtc/modules/video_coding/video_coding_impl.cc

Issue 1737013002: Reland of move ignored return code from modules. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 virtual ~VideoCodingModuleImpl() { own_event_factory_.reset(); } 87 virtual ~VideoCodingModuleImpl() { own_event_factory_.reset(); }
88 88
89 int64_t TimeUntilNextProcess() override { 89 int64_t TimeUntilNextProcess() override {
90 int64_t sender_time = sender_.TimeUntilNextProcess(); 90 int64_t sender_time = sender_.TimeUntilNextProcess();
91 int64_t receiver_time = receiver_.TimeUntilNextProcess(); 91 int64_t receiver_time = receiver_.TimeUntilNextProcess();
92 assert(sender_time >= 0); 92 assert(sender_time >= 0);
93 assert(receiver_time >= 0); 93 assert(receiver_time >= 0);
94 return VCM_MIN(sender_time, receiver_time); 94 return VCM_MIN(sender_time, receiver_time);
95 } 95 }
96 96
97 int32_t Process() override { 97 void Process() override {
98 int32_t sender_return = sender_.Process(); 98 sender_.Process();
99 int32_t receiver_return = receiver_.Process(); 99 receiver_.Process();
100 if (sender_return != VCM_OK)
101 return sender_return;
102 return receiver_return;
103 } 100 }
104 101
105 int32_t RegisterSendCodec(const VideoCodec* sendCodec, 102 int32_t RegisterSendCodec(const VideoCodec* sendCodec,
106 uint32_t numberOfCores, 103 uint32_t numberOfCores,
107 uint32_t maxPayloadSize) override { 104 uint32_t maxPayloadSize) override {
108 return sender_.RegisterSendCodec(sendCodec, numberOfCores, maxPayloadSize); 105 return sender_.RegisterSendCodec(sendCodec, numberOfCores, maxPayloadSize);
109 } 106 }
110 107
111 int32_t RegisterExternalEncoder(VideoEncoder* externalEncoder, 108 int32_t RegisterExternalEncoder(VideoEncoder* externalEncoder,
112 uint8_t payloadType, 109 uint8_t payloadType,
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 301
305 VideoCodingModule* VideoCodingModule::Create(Clock* clock, 302 VideoCodingModule* VideoCodingModule::Create(Clock* clock,
306 EventFactory* event_factory) { 303 EventFactory* event_factory) {
307 assert(clock); 304 assert(clock);
308 assert(event_factory); 305 assert(event_factory);
309 return new VideoCodingModuleImpl(clock, event_factory, false, nullptr, 306 return new VideoCodingModuleImpl(clock, event_factory, false, nullptr,
310 nullptr); 307 nullptr);
311 } 308 }
312 309
313 } // namespace webrtc 310 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/video_coding_impl.h ('k') | webrtc/modules/video_coding/video_coding_robustness_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698