Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

Issue 1737013002: Reland of move ignored return code from modules. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 update_estimate = remote_rate_.ValidEstimate(); 326 update_estimate = remote_rate_.ValidEstimate();
327 ssrcs = Keys(ssrcs_); 327 ssrcs = Keys(ssrcs_);
328 } 328 }
329 } 329 }
330 if (update_estimate) { 330 if (update_estimate) {
331 last_update_ms_ = now_ms; 331 last_update_ms_ = now_ms;
332 observer_->OnReceiveBitrateChanged(ssrcs, target_bitrate_bps); 332 observer_->OnReceiveBitrateChanged(ssrcs, target_bitrate_bps);
333 } 333 }
334 } 334 }
335 335
336 int32_t RemoteBitrateEstimatorAbsSendTime::Process() { 336 void RemoteBitrateEstimatorAbsSendTime::Process() {}
337 return 0;
338 }
339 337
340 int64_t RemoteBitrateEstimatorAbsSendTime::TimeUntilNextProcess() { 338 int64_t RemoteBitrateEstimatorAbsSendTime::TimeUntilNextProcess() {
341 const int64_t kDisabledModuleTime = 1000; 339 const int64_t kDisabledModuleTime = 1000;
342 return kDisabledModuleTime; 340 return kDisabledModuleTime;
343 } 341 }
344 342
345 void RemoteBitrateEstimatorAbsSendTime::TimeoutStreams(int64_t now_ms) { 343 void RemoteBitrateEstimatorAbsSendTime::TimeoutStreams(int64_t now_ms) {
346 for (Ssrcs::iterator it = ssrcs_.begin(); it != ssrcs_.end();) { 344 for (Ssrcs::iterator it = ssrcs_.begin(); it != ssrcs_.end();) {
347 if ((now_ms - it->second) > kStreamTimeOutMs) { 345 if ((now_ms - it->second) > kStreamTimeOutMs) {
348 ssrcs_.erase(it++); 346 ssrcs_.erase(it++);
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 return true; 392 return true;
395 } 393 }
396 394
397 void RemoteBitrateEstimatorAbsSendTime::SetMinBitrate(int min_bitrate_bps) { 395 void RemoteBitrateEstimatorAbsSendTime::SetMinBitrate(int min_bitrate_bps) {
398 // Called from both the configuration thread and the network thread. Shouldn't 396 // Called from both the configuration thread and the network thread. Shouldn't
399 // be called from the network thread in the future. 397 // be called from the network thread in the future.
400 rtc::CritScope lock(&crit_); 398 rtc::CritScope lock(&crit_);
401 remote_rate_.SetMinBitrate(min_bitrate_bps); 399 remote_rate_.SetMinBitrate(min_bitrate_bps);
402 } 400 }
403 } // namespace webrtc 401 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698