Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1736513003: MB: Fix typo in device mixin. (Closed)

Created:
4 years, 9 months ago by kjellander_webrtc
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Fix typo in device mixin. In https://codereview.webrtc.org/1735593002/ there was a typo (that the presubmit doesn't catch) that caused the signing arg to be missing for GN. BUG=589510 TBR=dpranke@chromium.org Committed: https://chromium.googlesource.com/external/webrtc/+/0c74ae1e4d1d0bd7f56fe23d696595cb6b92a743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/build/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
4 years, 9 months ago (2016-02-25 07:40:57 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0c74ae1e4d1d0bd7f56fe23d696595cb6b92a743 Cr-Commit-Position: refs/heads/master@{#11757}
4 years, 9 months ago (2016-02-25 07:41:21 UTC) #5
kjellander_webrtc
Committed patchset #1 (id:1) manually as 0c74ae1e4d1d0bd7f56fe23d696595cb6b92a743 (presubmit successful).
4 years, 9 months ago (2016-02-25 07:41:24 UTC) #7
Dirk Pranke
4 years, 9 months ago (2016-02-25 17:29:54 UTC) #8
Message was sent while issue was closed.
lgtm. It wouldn't be hard to modify the code to catch this sort of thing ...

Powered by Google App Engine
This is Rietveld 408576698