Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1735593002: MB: Add initial mb_config.pyl configuration file. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, smut
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Add initial mb_config.pyl configuration file. This is only needed and used by the iOS GN bots so far, but more bots will start using this in the future as we'll be migrating from GYP to GN at some point. Buildbot configuration is done in https://codereview.chromium.org/1730353002 BUG=589510 R=dpranke@chromium.org Committed: https://crrev.com/861dcb7eddd295b529120219794c246a8a1dcccf Cr-Commit-Position: refs/heads/master@{#11752}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Set ios_enable_code_signing=false for GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -0 lines) Patch
A webrtc/build/PRESUBMIT.py View 1 chunk +34 lines, -0 lines 0 comments Download
A webrtc/build/mb_config.pyl View 1 1 chunk +137 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_webrtc
https://codereview.webrtc.org/1735593002/diff/40001/webrtc/build/PRESUBMIT.py File webrtc/build/PRESUBMIT.py (right): https://codereview.webrtc.org/1735593002/diff/40001/webrtc/build/PRESUBMIT.py#newcode14 webrtc/build/PRESUBMIT.py:14: mb_script = input_api.os_path.join(input_api.PresubmitLocalPath(), '..', This was neat; that it ...
4 years, 10 months ago (2016-02-24 18:18:42 UTC) #5
kjellander_webrtc
Found the ios_enable_code_signing=false setting... https://codereview.webrtc.org/1735593002/diff/40001/webrtc/build/mb_config.pyl File webrtc/build/mb_config.pyl (right): https://codereview.webrtc.org/1735593002/diff/40001/webrtc/build/mb_config.pyl#newcode58 webrtc/build/mb_config.pyl:58: # TODO(kjellander): Figure out if ...
4 years, 10 months ago (2016-02-24 18:33:03 UTC) #6
Dirk Pranke
lgtm. https://codereview.webrtc.org/1735593002/diff/40001/webrtc/build/PRESUBMIT.py File webrtc/build/PRESUBMIT.py (right): https://codereview.webrtc.org/1735593002/diff/40001/webrtc/build/PRESUBMIT.py#newcode14 webrtc/build/PRESUBMIT.py:14: mb_script = input_api.os_path.join(input_api.PresubmitLocalPath(), '..', On 2016/02/24 18:18:42, kjellander ...
4 years, 10 months ago (2016-02-24 20:07:29 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 20:37:04 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/861dcb7eddd295b529120219794c246a8a1dcccf
Cr-Commit-Position: refs/heads/master@{#11752}

Powered by Google App Engine
This is Rietveld 408576698