Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Side by Side Diff: webrtc/video/vie_channel.h

Issue 1734933002: Move RTP stats histograms from VieChannel to SendStatisticsProxy. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Assert diff of RtpPacketCounter is valid Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/send_statistics_proxy_unittest.cc ('k') | webrtc/video/vie_channel.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 size_t num_modules); 197 size_t num_modules);
198 198
199 // Assumed to be protected. 199 // Assumed to be protected.
200 void StartDecodeThread(); 200 void StartDecodeThread();
201 void StopDecodeThread(); 201 void StopDecodeThread();
202 202
203 void ProcessNACKRequest(const bool enable); 203 void ProcessNACKRequest(const bool enable);
204 // Compute NACK list parameters for the buffering mode. 204 // Compute NACK list parameters for the buffering mode.
205 int GetRequiredNackListSize(int target_delay_ms); 205 int GetRequiredNackListSize(int target_delay_ms);
206 206
207 void UpdateHistograms();
208
209 // ViEChannel exposes methods that allow to modify observers and callbacks 207 // ViEChannel exposes methods that allow to modify observers and callbacks
210 // to be modified. Such an API-style is cumbersome to implement and maintain 208 // to be modified. Such an API-style is cumbersome to implement and maintain
211 // at all the levels when comparing to only setting them at construction. As 209 // at all the levels when comparing to only setting them at construction. As
212 // so this class instantiates its children with a wrapper that can be modified 210 // so this class instantiates its children with a wrapper that can be modified
213 // at a later time. 211 // at a later time.
214 template <class T> 212 template <class T>
215 class RegisterableCallback : public T { 213 class RegisterableCallback : public T {
216 public: 214 public:
217 RegisterableCallback() : callback_(NULL) {} 215 RegisterableCallback() : callback_(NULL) {}
218 216
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 int64_t last_rtt_ms_ GUARDED_BY(crit_); 314 int64_t last_rtt_ms_ GUARDED_BY(crit_);
317 315
318 // RtpRtcp modules, declared last as they use other members on construction. 316 // RtpRtcp modules, declared last as they use other members on construction.
319 const std::vector<RtpRtcp*> rtp_rtcp_modules_; 317 const std::vector<RtpRtcp*> rtp_rtcp_modules_;
320 size_t num_active_rtp_rtcp_modules_ GUARDED_BY(crit_); 318 size_t num_active_rtp_rtcp_modules_ GUARDED_BY(crit_);
321 }; 319 };
322 320
323 } // namespace webrtc 321 } // namespace webrtc
324 322
325 #endif // WEBRTC_VIDEO_VIE_CHANNEL_H_ 323 #endif // WEBRTC_VIDEO_VIE_CHANNEL_H_
OLDNEW
« no previous file with comments | « webrtc/video/send_statistics_proxy_unittest.cc ('k') | webrtc/video/vie_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698