tools/ubsan/blacklist.txt - Issue 1734883003: iSAC entropy coder: Avoid signed integer overflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/ubsan/blacklist.txt

Issue 1734883003: iSAC entropy coder: Avoid signed integer overflow (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c » ('j') | webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/ubsan/blacklist.txt

diff --git a/tools/ubsan/blacklist.txt b/tools/ubsan/blacklist.txt

index d48b31d2a9ca9dcd0c7ec09257baf299a9cfdfb5..1ddbbadb16e98a4c46322ae6a6c6f7f5ba94e0ad 100644

--- a/tools/ubsan/blacklist.txt

+++ b/tools/ubsan/blacklist.txt

@@ -15,10 +15,7 @@ src:*/third_party/yasm/*

src:*/usr/*

#############################################################################

-# iSAC exhibits a few problems (entropy coding and a unit test).

# https://bugs.chromium.org/p/webrtc/issues/detail?id=5513

-src:*/webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c

-src:*/webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c

fun:*FilterBanksTest*CalculateResidualEnergyTester*

#############################################################################

@@ -35,4 +32,4 @@ src:*/webrtc/common_audio/signal_processing/resample_by_2_internal.c

fun:*WebRtcSpl_AddSatW32*

fun:*WebRtcSpl_SubSatW32*

fun:*WebRtcSpl_DivW32HiLow*

-fun:*GmmProbability*

+fun:*GmmProbability*