Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1734583002: Fix ubsan warnings in BWE tests. (Closed)

Created:
4 years, 10 months ago by stefan-webrtc
Modified:
4 years, 10 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix ubsan warnings in BWE tests. BUG=webrtc:5490 R=pbos@webrtc.org Committed: https://crrev.com/837b39e8f4ce59ff5896c8a5a7bdd7c934f36312 Cr-Commit-Position: refs/heads/master@{#11741}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc View 1 1 chunk +8 lines, -7 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
stefan-webrtc
.
4 years, 10 months ago (2016-02-24 11:01:46 UTC) #1
stefan-webrtc
4 years, 10 months ago (2016-02-24 11:58:23 UTC) #3
pbos-webrtc
lgtm
4 years, 10 months ago (2016-02-24 12:59:41 UTC) #5
stefan-webrtc
Committed patchset #3 (id:40001) manually as 837b39e8f4ce59ff5896c8a5a7bdd7c934f36312 (presubmit successful).
4 years, 10 months ago (2016-02-24 13:03:16 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 13:03:17 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/837b39e8f4ce59ff5896c8a5a7bdd7c934f36312
Cr-Commit-Position: refs/heads/master@{#11741}

Powered by Google App Engine
This is Rietveld 408576698