webrtc/media/engine/webrtcvideocapturer.cc - Issue 1733673002: Removed unused cricket::VideoCapturer methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideocapturer.cc

Issue 1733673002: Removed unused cricket::VideoCapturer methods (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed thread checker for android. SetCaptureFormat is called on the thread where the capturer is cr… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/webrtcvideocapturer.cc

diff --git a/webrtc/media/engine/webrtcvideocapturer.cc b/webrtc/media/engine/webrtcvideocapturer.cc

index 114556411c63870ddccfdd90df42938e21a2c956..a1848e933c82a6e0e2ca26865e839c4d06c6eeb0 100644

--- a/webrtc/media/engine/webrtcvideocapturer.cc

+++ b/webrtc/media/engine/webrtcvideocapturer.cc

@@ -262,7 +262,7 @@ void WebRtcVideoCapturer::OnSinkWantsChanged(const rtc::VideoSinkWants& wants) {

CaptureState WebRtcVideoCapturer::Start(const VideoFormat& capture_format) {

if (!module_) {

LOG(LS_ERROR) << "The capturer has not been initialized";

- return CS_NO_DEVICE;

+ return CS_FAILED;

}

if (start_thread_) {

LOG(LS_ERROR) << "The capturer is already running";