Removed unused cricket::VideoCapturer methods

Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);
void ClearAspectRatio();
ool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only one thread. Construction can happen on a separate thred.
It does not add restrictions on what thread frames are delivered on though.

There is more features in VideoCapturer::Onframe related to screen share in ARGB that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
Committed: https://crrev.com/e9c0cdff2dad2553b6ff6820c0c7429cb2854861
Cr-Commit-Position: refs/heads/master@{#11773}

[perkj_webrtc, 2016-02-24 16:25:15]

Description was changed from

==========
Removed unused cricket::VideoCapturer methods
This cl removes methods from cricket::VideoCapturer that is currently not used.
There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=
==========

to

==========
Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);	
void ClearAspectRatio();
ool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const 
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred. 
It does not add restrictions on what thread frames are delivered on though. 


There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=
==========

[perkj_webrtc, 2016-02-24 16:27:09]

Description was changed from

==========
Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);	
void ClearAspectRatio();
ool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const 
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred. 
It does not add restrictions on what thread frames are delivered on though. 


There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=
==========

to

==========
Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);	
void ClearAspectRatio();
ool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const 
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred. 
It does not add restrictions on what thread frames are delivered on though. 


There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
==========

[perkj_webrtc, 2016-02-24 16:27:09]

perkj@webrtc.org changed reviewers:
+ magjed@webrtc.org, pthatcher@webrtc.org

[perkj_webrtc, 2016-02-24 16:27:24]

please?

[pthatcher1, 2016-02-25 06:44:24]

lgtm

https://codereview.webrtc.org/1733673002/diff/1/webrtc/api/videosource.cc
File webrtc/api/videosource.cc (left):

https://codereview.webrtc.org/1733673002/diff/1/webrtc/api/videosource.cc#old...
webrtc/api/videosource.cc:380: void VideoSource::Restart() {
FYI, I think this is also never called.

[perkj_webrtc, 2016-02-25 10:45:49]

https://codereview.webrtc.org/1733673002/diff/1/webrtc/api/videosource.cc
File webrtc/api/videosource.cc (left):

https://codereview.webrtc.org/1733673002/diff/1/webrtc/api/videosource.cc#old...
webrtc/api/videosource.cc:380: void VideoSource::Restart() {
On 2016/02/25 06:44:24, pthatcher1 wrote:
> FYI, I think this is also never called.

Used by Java VideoSource. On android- glaznev wanted this to easely be able to
stop/restart the capturer when the app goes to background.

[perkj_webrtc, 2016-02-25 10:46:21]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-02-25 10:46:21]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1733673002/#ps10001 (title:
"Fixed thread checker for android. SetCaptureFormat is called on the thread
where the capturer is cr…")

[commit-bot: I haz the power, 2016-02-25 10:46:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1733673002/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1733673002/10001

[commit-bot: I haz the power, 2016-02-25 11:42:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 11:42:41]

Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11195)

[perkj_webrtc, 2016-02-25 14:43:27]

Patchset #2 (id:10001) has been deleted

[perkj_webrtc, 2016-02-25 14:43:32]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-02-25 14:43:33]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1733673002/#ps30001 (title:
"Fixed thread checker for android. SetCaptureFormat is called on the thread
where the capturer is cr…")

[commit-bot: I haz the power, 2016-02-25 14:43:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1733673002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1733673002/30001

[commit-bot: I haz the power, 2016-02-25 16:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:44:18]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[perkj_webrtc, 2016-02-26 07:31:03]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-02-26 07:31:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1733673002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1733673002/30001

[commit-bot: I haz the power, 2016-02-26 07:36:18]

Description was changed from

==========
Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);	
void ClearAspectRatio();
ool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const 
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred. 
It does not add restrictions on what thread frames are delivered on though. 


There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
==========

to

==========
Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);	
void ClearAspectRatio();
ool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const 
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred. 
It does not add restrictions on what thread frames are delivered on though. 


There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
==========

[commit-bot: I haz the power, 2016-02-26 07:36:19]

Committed patchset #2 (id:30001)

[commit-bot: I haz the power, 2016-02-26 07:36:31]

Description was changed from

==========
Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);	
void ClearAspectRatio();
ool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const 
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred. 
It does not add restrictions on what thread frames are delivered on though. 


There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426
==========

to

==========
Removed unused cricket::VideoCapturer methods:

void UpdateAspectRatio(int ratio_w, int ratio_h);
void ClearAspectRatio();
ool Pause(bool paused);
Restart(const VideoFormat& capture_format);
MuteToBlackThenPause(bool muted);
IsMuted() const
set_square_pixel_aspect_ratio
bool square_pixel_aspect_ratio()

This cl also remove the use of messages and posting of state change.
Further more - a thread checker is added to make sure methods are called on only
one thread. Construction can happen on a separate thred.
It does not add restrictions on what thread frames are delivered on though.

There is more features in VideoCapturer::Onframe related to screen share in ARGB
that probably can be cleaned up in a follow up cl.

BUG=webrtc:5426

Committed: https://crrev.com/e9c0cdff2dad2553b6ff6820c0c7429cb2854861
Cr-Commit-Position: refs/heads/master@{#11773}
==========

[commit-bot: I haz the power, 2016-02-26 07:36:31]

Patchset 2 (id:??) landed as
https://crrev.com/e9c0cdff2dad2553b6ff6820c0c7429cb2854861
Cr-Commit-Position: refs/heads/master@{#11773}

[perkj_webrtc, 2016-02-26 10:53:48]

A revert of this CL (patchset #2 id:30001) has been created in
https://codereview.webrtc.org/1740963002/ by perkj@webrtc.org.

The reason for reverting is: Breaks
remoting::protocol::WebrtcVideoCapturerAdapter::Pause'

See
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build....