Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: webrtc/modules/congestion_controller/congestion_controller.cc

Issue 1732863002: Break out pacer thread from CongestionController to increase testability. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/congestion_controller.cc
diff --git a/webrtc/modules/congestion_controller/congestion_controller.cc b/webrtc/modules/congestion_controller/congestion_controller.cc
index 0282e8148e9f5c8274ff88dfda56f6577d014b5f..50074d50e4477e4bf4be435755b83abda7cd4e81 100644
--- a/webrtc/modules/congestion_controller/congestion_controller.cc
+++ b/webrtc/modules/congestion_controller/congestion_controller.cc
@@ -147,7 +147,6 @@ CongestionController::CongestionController(
0)),
remote_bitrate_estimator_(
new WrappingBitrateEstimator(remote_bitrate_observer, clock_)),
- pacer_thread_(ProcessThread::Create("PacerThread")),
// Constructed last as this object calls the provided callback on
// construction.
bitrate_controller_(
@@ -160,15 +159,9 @@ CongestionController::CongestionController(
clock_));
transport_feedback_adapter_.GetBitrateEstimator()->SetMinBitrate(
min_bitrate_bps_);
- pacer_thread_->RegisterModule(pacer_.get());
- pacer_thread_->RegisterModule(&remote_estimator_proxy_);
- pacer_thread_->Start();
}
CongestionController::~CongestionController() {
- pacer_thread_->Stop();
- pacer_thread_->DeRegisterModule(pacer_.get());
- pacer_thread_->DeRegisterModule(&remote_estimator_proxy_);
}

Powered by Google App Engine
This is Rietveld 408576698