Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1731153002: Replace scoped_ptr with unique_ptr in webrtc/common_audio/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1, philipel
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/common_audio/ (This is a re-land---without the real_fourier.h changes---of 11716, which was reverted in 11726.) BUG=webrtc:5520 Committed: https://crrev.com/c2b785df5d4327fd96680f5efe8b241da7b5ce30 Cr-Commit-Position: refs/heads/master@{#11742}

Patch Set 1 : original CL #

Patch Set 2 : revert real_fourier.h + make changes so that things compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -89 lines) Patch
M webrtc/common_audio/audio_converter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/common_audio/audio_converter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/audio_converter_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/audio_ring_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/audio_ring_buffer_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/common_audio/blocker.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/common_audio/blocker_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/common_audio/channel_buffer.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/common_audio/channel_buffer.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/common_audio/fir_filter.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/common_audio/fir_filter_neon.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/common_audio/fir_filter_sse.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/common_audio/fir_filter_sse.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_audio/fir_filter_unittest.cc View 11 chunks +12 lines, -11 lines 0 comments Download
M webrtc/common_audio/include/audio_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/lapped_transform.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/lapped_transform.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/common_audio/real_fourier_ooura.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/real_fourier_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/resampler/include/push_resampler.h View 2 chunks +8 lines, -7 lines 0 comments Download
M webrtc/common_audio/resampler/push_sinc_resampler.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/common_audio/resampler/push_sinc_resampler_unittest.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler_unittest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M webrtc/common_audio/ring_buffer_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/common_audio/sparse_fir_filter_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_suppressor.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-24 10:53:35 UTC) #3
kjellander_webrtc
lgtm, you can ignore the mac_baremetal failure as it's a flake (CCing sheriff for disabling/filing ...
4 years, 10 months ago (2016-02-24 11:37:24 UTC) #4
hlundin-webrtc
lgtm
4 years, 10 months ago (2016-02-24 11:40:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731153002/20001
4 years, 10 months ago (2016-02-24 11:51:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 13:22:36 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 13:22:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2b785df5d4327fd96680f5efe8b241da7b5ce30
Cr-Commit-Position: refs/heads/master@{#11742}

Powered by Google App Engine
This is Rietveld 408576698