Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1730113002: Reland of Add tools/mb to setup_links.py (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add tools/mb to setup_links.py (patchset #1 id:1 of https://codereview.webrtc.org/1691723003/ ) Reason for revert: Actually, we're going to need this soon, so I'm going to add it back again. We'll use it as part of the future GN migration. Original issue's description: > Revert of Add tools/mb to setup_links.py (patchset #1 id:1 of https://codereview.webrtc.org/1692543002/ ) > > Reason for revert: > Doesn't solve the problem and MB is actually hardcoded to use gyp_chromium when running in GYP mode, so it's better to clean this up for now. > > Original issue's description: > > Add tools/mb to setup_links.py > > > > I believe this is needed in order to setup the iOS simulator bots > > using the ios recipe module. We'll also most likely use MB in the future > > when moving over from GYP to GN (since that's the sole purpose of the tool: > > to make such a migration easier). > > > > BUG=chromium:498746 > > NOTRY=True > > TBR=phoglund@webrtc.org > > > > Committed: https://crrev.com/68da769ab9579cac98fe4da7fb5da6dbb3842216 > > Cr-Commit-Position: refs/heads/master@{#11575} > > TBR=phoglund@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:498746 > > Committed: https://crrev.com/67ca0e16501d5c9179d3003a38a7cefc7cd3e259 > Cr-Commit-Position: refs/heads/master@{#11577} TBR=phoglund@webrtc.org NOTRY=True Committed: https://crrev.com/17849fcc8bf22004ab111f61c5e261c39efc24d4 Cr-Commit-Position: refs/heads/master@{#11732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M setup_links.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
Created Reland of Add tools/mb to setup_links.py
4 years, 10 months ago (2016-02-24 08:01:04 UTC) #1
kjellander_webrtc
4 years, 10 months ago (2016-02-24 08:02:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730113002/1
4 years, 10 months ago (2016-02-24 08:02:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 08:04:48 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 08:04:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17849fcc8bf22004ab111f61c5e261c39efc24d4
Cr-Commit-Position: refs/heads/master@{#11732}

Powered by Google App Engine
This is Rietveld 408576698