Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1729893002: Reland: Prevent data race in MessageQueue. (Closed)

Created:
4 years, 10 months ago by joachim
Modified:
4 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland: Prevent data race in MessageQueue. The CL prevents a data race in MessageQueue where the variable "ss_" is modified without a lock while sometimes read inside a lock. Also thread annotations have been added to the MessageQueue class. This was already reviewed and landed in https://codereview.webrtc.org/1675923002/ but failed in Chromium GN builds due to sharedexclusivelock.cc not being compiled in these builds. This changed in https://codereview.webrtc.org/1712773003/ so the reland should work fine now. BUG=webrtc:5496 Committed: https://crrev.com/9ccedc38f6ba113a95cfcd2db59112051ab11160 Cr-Commit-Position: refs/heads/master@{#11758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -37 lines) Patch
M webrtc/base/messagequeue.h View 3 chunks +14 lines, -8 lines 0 comments Download
M webrtc/base/messagequeue.cc View 5 chunks +52 lines, -27 lines 0 comments Download
M webrtc/base/thread.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joachim
Ptal
4 years, 10 months ago (2016-02-23 23:54:45 UTC) #2
pthatcher1
lgtm
4 years, 10 months ago (2016-02-25 06:48:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729893002/1
4 years, 10 months ago (2016-02-25 08:16:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 09:15:00 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 09:15:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ccedc38f6ba113a95cfcd2db59112051ab11160
Cr-Commit-Position: refs/heads/master@{#11758}

Powered by Google App Engine
This is Rietveld 408576698