Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issue 1728743002: iOS: Fix JSON for tryserver configurations. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
smut
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Fix JSON for tryserver configurations. Use boolean values instead of strings. With this landed https://codereview.chromium.org/1723033003/ can be reverted. BUG=498746 R=smut@google.com Committed: https://crrev.com/71d9721bdcd5d4b9282c8fec770fb45ff983bb2a Cr-Commit-Position: refs/heads/master@{#11724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M webrtc/build/ios/tryserver.webrtc/ios32_sim_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios64_gn_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios64_gn_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios64_sim_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_arm64_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_arm64_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_rel.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_webrtc
PTAL
4 years, 10 months ago (2016-02-23 20:06:32 UTC) #4
smut
lgtm
4 years, 10 months ago (2016-02-23 20:09:38 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/71d9721bdcd5d4b9282c8fec770fb45ff983bb2a Cr-Commit-Position: refs/heads/master@{#11724}
4 years, 10 months ago (2016-02-23 20:16:12 UTC) #8
kjellander_webrtc
4 years, 10 months ago (2016-02-23 20:16:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71d9721bdcd5d4b9282c8fec770fb45ff983bb2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698