Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1727583003: Only average positive quality stats. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
sprang, sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only average positive quality stats. Removes addition of at least one zero sample in webrtc_perf_tests that can skew stats differently depending on how often these stats are updated. Unclear if this skewing is different between now and before. BUG=chromium:585071, chromium:586216 R=sprang@google.com, sprang@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/b1eaa8df0d5e3589771cd4c4a9d6d7707b116a27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M webrtc/video/video_quality_test.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pbos-webrtc
PTAL
4 years, 10 months ago (2016-02-23 16:27:36 UTC) #1
sprang
lgtm
4 years, 10 months ago (2016-02-23 16:28:48 UTC) #3
sprang_webrtc
lgtm
4 years, 10 months ago (2016-02-23 16:29:29 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b1eaa8df0d5e3589771cd4c4a9d6d7707b116a27 Cr-Commit-Position: refs/heads/master@{#11720}
4 years, 10 months ago (2016-02-23 16:31:00 UTC) #8
pbos-webrtc
4 years, 10 months ago (2016-02-23 16:31:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1eaa8df0d5e3589771cd4c4a9d6d7707b116a27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698