Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1727353002: Reset indexer upon initialization in AudioLoop. (Closed)

Created:
4 years, 10 months ago by minyue-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reset indexer upon initialization in AudioLoop. The array is reset in Init() but not the indexer. This makes the start point undefined after Init() for re-initializing an AudioLoop. This can be fixed. BUG= Committed: https://crrev.com/58e08cbea85295ca7aca293c31117994b558e515 Cr-Commit-Position: refs/heads/master@{#11739}

Patch Set 1 #

Patch Set 2 : fixing a unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/opus_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/audio_loop.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
minyue-webrtc
Henrik, Here is a small CL for you to review. Thanks!
4 years, 10 months ago (2016-02-24 09:30:58 UTC) #3
minyue-webrtc
+flim The fixing triggers an earlier error. After Opus 1.1.2 update, the check on a ...
4 years, 10 months ago (2016-02-24 09:59:31 UTC) #6
hlundin-webrtc
Nice catch. LGTM.
4 years, 10 months ago (2016-02-24 10:41:26 UTC) #7
flim-webrtc
lgtm
4 years, 10 months ago (2016-02-24 11:43:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727353002/40001
4 years, 10 months ago (2016-02-24 11:44:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-24 11:49:22 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 11:49:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58e08cbea85295ca7aca293c31117994b558e515
Cr-Commit-Position: refs/heads/master@{#11739}

Powered by Google App Engine
This is Rietveld 408576698