Fix division by zero in FindTMMBRBoundingSet

Fix division by zero in FindTMMBRBoundingSet

BUG=webrtc:5490
Committed: https://crrev.com/f6ff9714c00c2c38a4498bbdf9a2cb17e8033cf3
Cr-Commit-Position: refs/heads/master@{#11749}

[danilchap, 2016-02-24 15:09:33]

danilchap@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-02-24 15:22:24]

Thanks for fixing

https://codereview.webrtc.org/1727273003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/tmmbr_help.cc (right):

https://codereview.webrtc.org/1727273003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/tmmbr_help.cc:304: numCandidates--;
--numCandidates

https://codereview.webrtc.org/1727273003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/tmmbr_help.cc:348: float(packet_overhead_bits);
static_cast<float>

https://codereview.webrtc.org/1727273003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/tmmbr_help.cc:431: uint32_t packet_overhead_bits
=
make this a float instead to avoid the cast below.

[stefan-webrtc, 2016-02-24 15:22:28]

lgtm

[danilchap, 2016-02-24 15:45:46]

https://codereview.webrtc.org/1727273003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/tmmbr_help.cc (right):

https://codereview.webrtc.org/1727273003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/tmmbr_help.cc:304: numCandidates--;
On 2016/02/24 15:22:23, stefan-webrtc (holmer) wrote:
> --numCandidates

Would prefer to follow 'local' style: other same lines in this file use
post-decrement.
I have a plan (and CL) completely rewrite this function eliminating
numCandidates variable in the process.

https://codereview.webrtc.org/1727273003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/tmmbr_help.cc:348: float(packet_overhead_bits);
On 2016/02/24 15:22:23, stefan-webrtc (holmer) wrote:
> static_cast<float>

Done.

https://codereview.webrtc.org/1727273003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/tmmbr_help.cc:431: uint32_t packet_overhead_bits
=
On 2016/02/24 15:22:23, stefan-webrtc (holmer) wrote:
> make this a float instead to avoid the cast below.

Done.

[danilchap, 2016-02-24 17:22:23]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-02-24 17:22:23]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1727273003/#ps20001 (title:
" ")

[commit-bot: I haz the power, 2016-02-24 17:22:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1727273003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1727273003/20001

[commit-bot: I haz the power, 2016-02-24 17:23:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-24 17:24:00]

Description was changed from

==========
Fix division by zero in FindTMMBRBoundingSet

BUG=webrtc:5490
==========

to

==========
Fix division by zero in FindTMMBRBoundingSet

BUG=webrtc:5490

Committed: https://crrev.com/f6ff9714c00c2c38a4498bbdf9a2cb17e8033cf3
Cr-Commit-Position: refs/heads/master@{#11749}
==========

[commit-bot: I haz the power, 2016-02-24 17:24:01]

Patchset 2 (id:??) landed as
https://crrev.com/f6ff9714c00c2c38a4498bbdf9a2cb17e8033cf3
Cr-Commit-Position: refs/heads/master@{#11749}