Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: webrtc/api/objc/RTCPeerConnection+Stats.mm

Issue 1726213002: Compile rtc_api_objc on Mac. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Update TODO format Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/objc/RTCPeerConnection.h ('k') | webrtc/api/objc/RTCStatsReport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/objc/RTCPeerConnection+Stats.mm
diff --git a/webrtc/api/objc/RTCPeerConnection+Stats.mm b/webrtc/api/objc/RTCPeerConnection+Stats.mm
index 5032c84e54b6497ff43cc4900707012aaa1d72f8..6a506d4aaac9e4d5aa204b831252f8c3477274a9 100644
--- a/webrtc/api/objc/RTCPeerConnection+Stats.mm
+++ b/webrtc/api/objc/RTCPeerConnection+Stats.mm
@@ -16,12 +16,15 @@
#import "webrtc/api/objc/RTCStatsReport+Private.h"
#import "webrtc/base/objc/NSString+StdString.h"
+// TODO(hjon): Update nullability types. See http://crbug/webrtc/5592
+
namespace webrtc {
class StatsObserverAdapter : public StatsObserver {
public:
StatsObserverAdapter(void (^completionHandler)
- (NSArray<RTCStatsReport *> *stats)) {
+ (NSArray *stats)) {
+ // (NSArray<RTCStatsReport *> *stats)) {
completion_handler_ = completionHandler;
}
@@ -42,7 +45,8 @@ class StatsObserverAdapter : public StatsObserver {
}
private:
- void (^completion_handler_)(NSArray<RTCStatsReport *> *stats);
+ void (^completion_handler_)(NSArray *stats);
+ // void (^completion_handler_)(NSArray<RTCStatsReport *> *stats);
};
} // namespace webrtc
@@ -51,7 +55,8 @@ class StatsObserverAdapter : public StatsObserver {
- (void)statsForTrack:(RTCMediaStreamTrack *)mediaStreamTrack
statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel
completionHandler:
- (void (^)(NSArray<RTCStatsReport *> *stats))completionHandler {
+ (void (^)(NSArray *stats))completionHandler {
+ // (void (^)(NSArray<RTCStatsReport *> *stats))completionHandler {
rtc::scoped_refptr<webrtc::StatsObserverAdapter> observer(
new rtc::RefCountedObject<webrtc::StatsObserverAdapter>
(completionHandler));
« no previous file with comments | « webrtc/api/objc/RTCPeerConnection.h ('k') | webrtc/api/objc/RTCStatsReport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698