Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: webrtc/api/objc/RTCIceServer.mm

Issue 1726213002: Compile rtc_api_objc on Mac. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Update TODO format Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/objc/RTCIceServer.h ('k') | webrtc/api/objc/RTCMediaConstraints.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/objc/RTCIceServer.mm
diff --git a/webrtc/api/objc/RTCIceServer.mm b/webrtc/api/objc/RTCIceServer.mm
index 057c69603b0cfb1f5e9c559bb9467c8bec1c7fe2..bdac700e554d14f7647ed719070180428a2850c3 100644
--- a/webrtc/api/objc/RTCIceServer.mm
+++ b/webrtc/api/objc/RTCIceServer.mm
@@ -14,19 +14,22 @@
#import "webrtc/base/objc/NSString+StdString.h"
@implementation RTCIceServer
+// TODO(hjon): Update nullability types. See http://crbug/webrtc/5592
@synthesize urlStrings = _urlStrings;
@synthesize username = _username;
@synthesize credential = _credential;
-- (instancetype)initWithURLStrings:(NSArray<NSString *> *)urlStrings {
+- (instancetype)initWithURLStrings:(NSArray *)urlStrings {
+// - (instancetype)initWithURLStrings:(NSArray<NSString *> *)urlStrings {
NSParameterAssert(urlStrings.count);
return [self initWithURLStrings:urlStrings
username:nil
credential:nil];
}
-- (instancetype)initWithURLStrings:(NSArray<NSString *> *)urlStrings
+- (instancetype)initWithURLStrings:(NSArray *)urlStrings
+// - (instancetype)initWithURLStrings:(NSArray<NSString *> *)urlStrings
username:(NSString *)username
credential:(NSString *)credential {
NSParameterAssert(urlStrings.count);
« no previous file with comments | « webrtc/api/objc/RTCIceServer.h ('k') | webrtc/api/objc/RTCMediaConstraints.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698