Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: webrtc/api/objc/RTCIceCandidate.h

Issue 1726213002: Compile rtc_api_objc on Mac. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add nullability attributes and comment out type arguments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/objc/RTCIceCandidate.h
diff --git a/webrtc/api/objc/RTCIceCandidate.h b/webrtc/api/objc/RTCIceCandidate.h
index 41ea69e9912a59e6417b9bde7c20cd3326066afa..5150a67574cc9a3ed878b55dfd5b3b6e5f5310c1 100644
--- a/webrtc/api/objc/RTCIceCandidate.h
+++ b/webrtc/api/objc/RTCIceCandidate.h
@@ -27,16 +27,16 @@ NS_ASSUME_NONNULL_BEGIN
@property(nonatomic, readonly) NSInteger sdpMLineIndex;
/** The SDP string for this candidate. */
-@property(nonatomic, readonly) NSString *sdp;
+@property(nonatomic, readonly, nonnull) NSString *sdp;
-- (instancetype)init NS_UNAVAILABLE;
+- (nonnull instancetype)init NS_UNAVAILABLE;
tkchin_webrtc 2016/02/24 22:39:18 shouldn't init returns be nullable? It's possible
/**
* Initialize an RTCIceCandidate from SDP.
*/
-- (instancetype)initWithSdp:(NSString *)sdp
- sdpMLineIndex:(NSInteger)sdpMLineIndex
- sdpMid:(nullable NSString *)sdpMid
+- (nonnull instancetype)initWithSdp:(nonnull NSString *)sdp
+ sdpMLineIndex:(NSInteger)sdpMLineIndex
+ sdpMid:(nullable NSString *)sdpMid
NS_DESIGNATED_INITIALIZER;
@end

Powered by Google App Engine
This is Rietveld 408576698