Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1726043002: Revert of Replace scoped_ptr with unique_ptr in webrtc/common_audio/ (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Replace scoped_ptr with unique_ptr in webrtc/common_audio/ (patchset #4 id:60001 of https://codereview.webrtc.org/1712513002/ ) Reason for revert: Breaks downstream compilation using webrtc/common_audio/real_fourier.h. Let's chat tomorrow on how to coordinate a re-land. Original issue's description: > Replace scoped_ptr with unique_ptr in webrtc/common_audio/ > > BUG=webrtc:5520 > > Committed: https://crrev.com/79d7a499c0c3e1de8f5ad1138236f0386701053f > Cr-Commit-Position: refs/heads/master@{#11716} TBR=henrik.lundin@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5520 Committed: https://crrev.com/e80f9d02185f026af003fee48666bb230ece86de Cr-Commit-Position: refs/heads/master@{#11726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -113 lines) Patch
M webrtc/common_audio/audio_converter.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/common_audio/audio_converter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/audio_converter_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/audio_ring_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/audio_ring_buffer_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/common_audio/blocker.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/common_audio/blocker_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/common_audio/channel_buffer.h View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/common_audio/channel_buffer.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M webrtc/common_audio/fir_filter.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/common_audio/fir_filter_neon.h View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/common_audio/fir_filter_sse.h View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/common_audio/fir_filter_sse.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/fir_filter_unittest.cc View 11 chunks +11 lines, -12 lines 0 comments Download
M webrtc/common_audio/include/audio_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_audio/lapped_transform.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/real_fourier.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/common_audio/real_fourier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/real_fourier_ooura.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/real_fourier_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_audio/resampler/include/push_resampler.h View 2 chunks +7 lines, -8 lines 0 comments Download
M webrtc/common_audio/resampler/push_sinc_resampler.h View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/common_audio/resampler/push_sinc_resampler_unittest.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler.h View 2 chunks +5 lines, -6 lines 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler_unittest.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M webrtc/common_audio/ring_buffer_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M webrtc/common_audio/sparse_fir_filter_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_suppressor.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kjellander_webrtc
Created Revert of Replace scoped_ptr with unique_ptr in webrtc/common_audio/
4 years, 10 months ago (2016-02-23 21:32:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726043002/1
4 years, 10 months ago (2016-02-23 21:33:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 21:33:37 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e80f9d02185f026af003fee48666bb230ece86de Cr-Commit-Position: refs/heads/master@{#11726}
4 years, 10 months ago (2016-02-23 21:33:47 UTC) #5
hlundin-webrtc
4 years, 10 months ago (2016-02-24 08:40:16 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698