Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 1725363003: Move RTP module activation into PayloadRouter. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_sender.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
index 97469ca35ecf27defdfc971376e4d6ff6399b23d..f053f1be22a7c07af227c716df66643a50ee7a27 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
@@ -304,7 +304,8 @@ int32_t RTPSender::RegisterPayload(
uint32_t frequency,
size_t channels,
uint32_t rate) {
- assert(payload_name);
+ RTC_DCHECK_LT(strlen(payload_name),
+ static_cast<size_t>(RTP_PAYLOAD_NAME_SIZE));
stefan-webrtc 2016/02/26 14:49:07 Can you instead change the type of this const?
pbos-webrtc 2016/02/26 14:58:55 This is stored in RtpUtility::Payload which has a
rtc::CritScope lock(&send_critsect_);
std::map<int8_t, RtpUtility::Payload*>::iterator it =

Powered by Google App Engine
This is Rietveld 408576698