Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 1725243007: Android MediaCodecVideoDecoder: Limit measured decode time to 200ms (Closed)

Created:
4 years, 10 months ago by magjed_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android MediaCodecVideoDecoder: Limit measured decode time to 200ms This change is done to remove abnormally high decode time measurements for H264 decoding. H264 decoding sometimes keeps a few frames as reference before outputting a new decoded frame. This pipeline causes some frames to get stuck when the source stops sending new frames. When the source starts sending frames again, the decode time measurements for the frames that were stuck will include the pause time, which can be arbitrary high. This CL is a simple fix for this problem by constraining the decode time values to a "reasonable" range. BUG=b/27306053 Committed: https://crrev.com/cedddbdf7b54541ce1786495ab9cc582b3ed58c4 Cr-Commit-Position: refs/heads/master@{#11792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M webrtc/api/java/src/org/webrtc/MediaCodecVideoDecoder.java View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
magjed_webrtc
Please take a look.
4 years, 10 months ago (2016-02-26 14:16:36 UTC) #3
perkj_webrtc
lgtm
4 years, 10 months ago (2016-02-26 14:28:23 UTC) #4
stefan-webrtc
lgtm
4 years, 10 months ago (2016-02-26 14:36:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725243007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725243007/1
4 years, 10 months ago (2016-02-26 15:53:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 17:36:08 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 17:36:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cedddbdf7b54541ce1786495ab9cc582b3ed58c4
Cr-Commit-Position: refs/heads/master@{#11792}

Powered by Google App Engine
This is Rietveld 408576698